[pull] main from motiondivision:main#213
Merged
Conversation
Thread scroll timeline metadata through MotionValue so that when a scroll-derived value is bound to an acceleratable CSS property (opacity, clipPath, filter), a native WAAPI animation is created and attached to the scroll timeline directly, bypassing JS per-frame updates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…cceleration - Expand CLAUDE.md testing section: document test types, Cypress E2E patterns, and scroll timeline acceleration test requirements - Fix chained useTransform bug: only propagate accelerate when input is a direct scroll progress value (times [0,1], keyframes [0,1]). Prevents incorrect WAAPI animations when transforms are chained. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…uard Replace verbose identity check (times/keyframes === [0,1]) with an isTransformed flag on AccelerateConfig. The first useTransform from scroll progress propagates acceleration with isTransformed: true; subsequent chained transforms see the flag and skip acceleration, falling back to the JS onChange path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous approach used a single requestAnimationFrame inside useEffect to report animation counts as text content. This was unreliable in CI because the RAF could fire before the VisualElement had created the WAAPI animation (e.g. due to StrictMode double-mount timing). Now Cypress checks element.getAnimations() directly in .should() callbacks, which retry automatically until the assertion passes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add scroll timeline acceleration via useScroll + useTransform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )