[pull] master from supabase:master#728
Merged
pull[bot] merged 6 commits intocode:masterfrom Mar 5, 2026
Merged
Conversation
## What kind of change does this PR introduce? UI clarification. ## What is the current behavior? Our messaging around the compatibility of: - Dedicated pooler - Shared pooler ...in conjunction with the following connection types: - IPv4 - IPv6 - Direct connection ...is hard to parse. ## What is the new behavior? Copywriting clarifications to all of the above. Plus: - Broader copywriting clarifications to `IPV4SidePanel` - Replace deprecated `Radio` component with `RadioGroupItem_Shadcn_` as the former has little-to-no visual difference between unselected and selected states - Fixed `SidePanel` header gap and button labelling ## Additional context | Before | After | | --- | --- | | <img width="1024" height="563" alt="AWS Healthy Toolshed Supabase-4587771A-83A2-40E8-845B-256CE7E1A7DB" src="https://github.com/user-attachments/assets/09591fa1-48b8-4f3c-aaef-733af8dbdc9a" /> | <img width="1024" height="563" alt="AWS Healthy Toolshed Supabase-D56A2209-7421-43C2-A7C1-6C6965B3F008" src="https://github.com/user-attachments/assets/13a05e51-02a5-486a-9549-4c5fe049c65a" /> | | <img width="1024" height="563" alt="Add ons Supabase-10CC55BC-C3D8-4E40-9F73-31FFE8D7F42A" src="https://github.com/user-attachments/assets/73e206dc-58a3-4356-8e31-cf2ad74383f8" /> | <img width="1024" height="563" alt="Add ons Supabase-6311B7FE-4291-4982-968E-5EDBA76DE519" src="https://github.com/user-attachments/assets/503667ef-9b36-4d62-9872-53ac6b32f56f" /> | --------- Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Just clarified that the prize is an iPhone 17 Pro Max and the dinner is on a Wednesday, not a Tuesday.
## Summary - Adds a combined telemetry standards skill (`.claude/skills/telemetry-standards/SKILL.md`) that covers PostHog event naming conventions, property standards, review rules, and implementation guide - Intended to be imported as CodeRabbit learnings after merge so CodeRabbit can flag missing/incorrect tracking in PRs - Consolidates standards from existing `review-telemetry` and `implement-tracking` Claude commands into a single source of truth ## Post-merge steps ### 1. Import as CodeRabbit learnings (one-time) Comment on any PR in the repo: ``` @coderabbitai add a learning using .claude/skills/telemetry-standards/SKILL.md ``` This teaches CodeRabbit the telemetry standards. It will then: - Flag naming/property violations when `telemetry-constants.ts` is changed - Suggest adding `useTrack()` tracking when PRs add user-facing interactions without it - Propose event names following `[object]_[verb]` convention ### 2. Add path instructions in CodeRabbit web UI (optional, recommended) Go to CodeRabbit settings > Review > Path Instructions and add: - **Path:** `packages/common/telemetry-constants.ts` - **Instructions:** "Strictly enforce event naming: [object]_[verb] in snake_case. Only approved verbs: opened, clicked, submitted, created, removed, updated, retrieved, intended, evaluated, added. Properties must be camelCase and self-explanatory. Flag any usage of useSendEventMutation." ### 3. Remove old Claude commands (after verifying skill works) Delete `.claude/commands/review-telemetry.md` and `.claude/commands/implement-tracking.md` — this skill replaces both. Closes GROWTH-661
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Docs Update ## What is the current behavior? There is a troubleshooting guide on egress ## What is the new behavior? Just made light modifications to the troubleshooting guide ## Additional context None really. Just added a few small corrections and rewordings
…#43435) ## Summary - Updates exit survey question wording from "why" framing to "what made you" framing across both downgrade and project deletion flows - Based on [Jason Cohen's research](https://www.lennysnewsletter.com/p/why-your-product-stopped-growing) showing this reframing roughly doubles response rates and improves response quality by prompting users to recall a specific trigger event ### Changes | Location | Before | After | |---|---|---| | ExitSurveyModal (downgrade) | "Share with us why you're downgrading your plan." | "What made you decide to downgrade your plan?" | | DeleteProjectModal (delete) | "Help us improve by sharing why you're deleting your project." | "What made you decide to delete your project?" | ### No downstream impact - `CANCELLATION_REASONS` chip values unchanged - API payload fields (`reasons`, `additionalFeedback`, `exitAction`) unaffected - No PostHog event names or properties tied to question wording Closes GROWTH-657 ## Test plan - [ ] Trigger downgrade flow (paid plan → Free) and verify new wording appears - [ ] Trigger project deletion on a paid plan and verify new wording appears - [ ] Confirm survey submission still works end-to-end
This pull request makes a minor adjustment to the temporary API key validation logic. The key is now considered invalid if it has less than 30 seconds remaining before expiry, instead of the previous 20 seconds. This change helps avoid edge cases where a key might expire during use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )