Open
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sculptor/-/pipelines/2327622726 Status: Passed |
Taucher2003
reviewed
Feb 16, 2026
Member
Taucher2003
left a comment
Taucher2003
left a comment
There was a problem hiding this comment.
Does this have to be done with environment variables? Feels a bit wrong, but if that is the best option for a next app, then its fine.
Taucher2003
reviewed
Feb 17, 2026
Member
There was a problem hiding this comment.
Which values here are required?
NEXT_PUBLIC_SCULPTOR_VERSION and NEXT_PUBLIC_PICTOR_VERSION are managed by the set-edition script. Are the other two variables required or what are they used for?
More importantly, we don't know the SAGITTARIUS_GRAPHQL_URL during build, so this variable must be overridable at runtime without rebuilding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.