add build fixes and all the features of interactive video#1767
Open
KitsuneKode wants to merge 3 commits intocode100x:mainfrom
Open
add build fixes and all the features of interactive video#1767KitsuneKode wants to merge 3 commits intocode100x:mainfrom
KitsuneKode wants to merge 3 commits intocode100x:mainfrom
Conversation
Contributor
Author
Videorecording.2.mp4@devsargam @hkirat check this out, surely it will entertain you. |
1e27db0 to
9a3186e
Compare
Collaborator
|
@hkirat what do you think about this feature? |
Contributor
Contributor
Author
|
@hkirat @devsargam any updates?? |
Contributor
There was a problem hiding this comment.
PR Overview
This pull request introduces interactive video features with enhanced support for split-screen layouts, additional content types (websites, PDFs, Notion docs), and improved video metadata handling, while also fixing build issues. Key changes include:
- Implementation of a new ResizeBar component for resizable UI elements.
- Enhancements in content rendering and dual view mode with Notion integration.
- Updates to seed data, dependency lock adjustments, and UI improvements for video controls.
Reviewed Changes
| File | Description |
|---|---|
| src/components/ResizeBar.tsx | New component for handling resizable UIs. |
| src/components/admin/ContentRendererClient.tsx | Refactored content rendering with dual view and improved responsive layout. |
| src/store/atoms/filterContent.ts | Updated filter atom with type definition and default value. |
| src/store/atoms/trigger.ts | Added new pipTrigger atom for Picture-in-Picture control. |
| prisma/seed.ts | Enhanced seed functions for video metadata and content. |
| src/app/api/notion/route.ts | API endpoint updated to support a notionId parameter. |
| src/components/NotionRenderer.tsx | Modified Notion renderer to fetch data using notionId. |
| src/components/admin/UpdateVideoClient.tsx | Added radio group for selecting slides type in video update. |
| pnpm-lock.yaml | Dependency lock updates, including a downgrade for TypeScript. |
| src/components/VideoPlayer2.tsx | Integrated pipTrigger state for Picture-in-Picture mode handling. |
| src/components/FilterContent.tsx | Improved filter selection with type-safe default values. |
| src/components/admin/ContentRenderer.tsx | Exposed slidesType metadata for enhanced content support. |
| src/app/(main)/(pages)/watch-history/page.tsx | Added a ts-ignore comment for a specific TypeScript warning. |
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/components/VideoPlayer2.tsx:20
- The variable 'pip_Trigger' does not follow camelCase naming conventions. Consider renaming it to 'pipTrigger'.
const [pip_Trigger, setPip_Trigger] = useRecoilState(pipTrigger);
src/components/NotionRenderer.tsx:55
- The useEffect dependency array does not include 'notionId', which can lead to stale data if the notionId prop changes. Add 'notionId' to the dependency array.
}, [id]);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Feature added :
Screenshots and videos
Issues to resolve
Checklist before requesting a review