Feature/integ 3159/trust updates#170
Feature/integ 3159/trust updates#170ceciliastevens merged 3 commits intofeature/INTEG-3142/session-typefrom
Conversation
ceciliastevens
changed the base branch from
main
to
feature/INTEG-3142/session-type
| ::: incydr.enums.trusted_activities.BrowserDestination | ||
| :docstring: | ||
|
|
||
| * **AIRTABLE** = `"AIRTABLE"` |
There was a problem hiding this comment.
are we going to need to update these every time there is a new trusted activity browser destination? Are we going to be notified by the trusted activities team saying "hey, new browser destination just dropped"?
There was a problem hiding this comment.
alternatively, do we need to enum these out? Could we just let it rip as a string and they need to find the valid values out from... elsewhere? The trusted activity api docs, perhaps?
There was a problem hiding this comment.
We could just let it be a string. The permissible values are documented in the API documentation. I went with the enum because that's the pattern we're already doing for cloud services and email services, so I wanted to be consistent with it.
| ::: incydr.enums.trusted_activities.BrowserDestination | ||
| :docstring: | ||
|
|
||
| * **AIRTABLE** = `"AIRTABLE"` |
There was a problem hiding this comment.
alternatively, do we need to enum these out? Could we just let it rip as a string and they need to find the valid values out from... elsewhere? The trusted activity api docs, perhaps?
ceciliastevens
merged commit 8474aef
into
feature/INTEG-3142/session-type
3 participants
Adds some new features to trust