Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/views/shared/_meta_tags.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
%meta{ property: 'og:type', content: 'website' }
%meta{ property: 'og:url', content: request.original_url }
%meta{ property: 'og:image', content: image_url('codebar-social.jpg') }
%meta{ property: 'og:image:width', content: '1200' }
%meta{ property: 'og:image:height', content: '630' }
%meta{ property: 'og:image:alt', content: 'codebar - making tech more diverse and welcoming' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this has already been merged, but I thought it worth pointing out that alt text is intended for people and systems (eg assistive technology) that cannot see the contents of the image, to be able to understand what is in the image. The text as is ("codebar - making tech more diverse and welcoming"), is a piece of branding text and doesn't not help someone to understand what is in the image. I think that as an absolute minimum this should say "codebar logo".

Photo showing a crowd of people in the lower half, raising their hands in celebration. The top half of the photo shows the word 'codebar' in large writing alongside the codebar logo.

%meta{ property: 'og:description', content: 'Making tech more diverse and welcoming by bringing people together and helping teach programming skills.' }
%meta{ property: 'og:site_name', content: 'codebar' }
%meta{ property: 'og:locale', content: 'en_GB' }
Expand Down
2 changes: 1 addition & 1 deletion app/views/workshops/_meta_tags.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title = if workshop.virtual?
t('workshops.virtual.title_with_date', chapter: workshop.chapter.name, date: humanize_date(workshop.date_and_time))
else
t('workshop.title', host: workshop.host.name, date: humanize_date(workshop.date_and_time))
t('workshop.title', host: workshop.host&.name || 'codebar', date: humanize_date(workshop.date_and_time))
end
url = request.original_url
image = workshop.host.try(:image_url).presence || image_url('codebar-social.jpg')
Expand Down