Skip to content

perf: batch fetch flag comparison data#733

Merged
thomasrockhu-codecov merged 2 commits intomainfrom
seer/perf/batch-flag-comparison
Apr 15, 2026
Merged

perf: batch fetch flag comparison data#733
thomasrockhu-codecov merged 2 commits intomainfrom
seer/perf/batch-flag-comparison

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Feb 28, 2026

Fixes WORKER-PFZ. The issue was that: Flag comparison loop executes two database queries per flag, causing an N+1 query problem.

  • Previously, RepositoryFlag and CompareFlag records were fetched individually within a loop, leading to N+1 query issues.
  • This change refactors the _store_flag_comparison_data method to batch fetch RepositoryFlag and CompareFlag records.
  • RepositoryFlag records are now fetched in a single query for all relevant flag names.
  • CompareFlag records are now fetched in a single query for all relevant repository flag IDs.
  • This significantly reduces the number of database queries and improves performance.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 10940055

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Moderate risk because it changes database read/write patterns in the comparison worker (including creation + flush timing), which could affect correctness if edge cases around missing flags or IDs arise.

Overview
Improves flag comparison performance by eliminating an N+1 query pattern in create_or_update_flag_comparisons.

The task now bulk-loads RepositoryFlag rows for all head report flags, creates any missing flags in a single pass (then flushes once), then bulk-loads existing CompareFlag rows by repositoryflag_id before iterating to insert/update per-flag totals.

Reviewed by Cursor Bugbot for commit 1aec59c. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (d005280) to head (1aec59c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1305     1305           
  Lines       47994    48004   +10     
  Branches     1636     1636           
=======================================
+ Hits        44276    44286   +10     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.55% <0.00%> (-0.04%) ⬇️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sentry bot and others added 2 commits April 15, 2026 21:46
Use clearer dict names, one flush after creating missing repository flags,
a single short comment, and drop Seer-style block comments.

Made-with: Cursor
@thomasrockhu-codecov thomasrockhu-codecov force-pushed the seer/perf/batch-flag-comparison branch from d36d2a3 to 1aec59c Compare April 15, 2026 12:53
@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 43f5168 Apr 15, 2026
40 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the seer/perf/batch-flag-comparison branch April 15, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant