perf: batch fetch flag comparison data#733
Merged
thomasrockhu-codecov merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1305 1305
Lines 47994 48004 +10
Branches 1636 1636
=======================================
+ Hits 44276 44286 +10
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Use clearer dict names, one flush after creating missing repository flags, a single short comment, and drop Seer-style block comments. Made-with: Cursor
d36d2a3 to
1aec59c
Compare
thomasrockhu-codecov
approved these changes
Apr 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-PFZ. The issue was that: Flag comparison loop executes two database queries per flag, causing an N+1 query problem.
RepositoryFlagandCompareFlagrecords were fetched individually within a loop, leading to N+1 query issues._store_flag_comparison_datamethod to batch fetchRepositoryFlagandCompareFlagrecords.RepositoryFlagrecords are now fetched in a single query for all relevant flag names.CompareFlagrecords are now fetched in a single query for all relevant repository flag IDs.This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 10940055
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Moderate risk because it changes database read/write patterns in the comparison worker (including creation + flush timing), which could affect correctness if edge cases around missing flags or IDs arise.
Overview
Improves flag comparison performance by eliminating an N+1 query pattern in
create_or_update_flag_comparisons.The task now bulk-loads
RepositoryFlagrows for all head report flags, creates any missing flags in a single pass (then flushes once), then bulk-loads existingCompareFlagrows byrepositoryflag_idbefore iterating to insert/update per-flag totals.Reviewed by Cursor Bugbot for commit 1aec59c. Bugbot is set up for automated code reviews on this repo. Configure here.