Skip to content

fix: move upload finisher retries to 5#778

Closed
thomasrockhu-codecov wants to merge 1 commit intomainfrom
th/retries-to-5
Closed

fix: move upload finisher retries to 5#778
thomasrockhu-codecov wants to merge 1 commit intomainfrom
th/retries-to-5

Conversation

@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Mar 21, 2026

This is a potential reason why things are breaking on production. Backing this down to 5 to see if that's the case

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk configuration tweak that only changes the default retry behavior for the upload finisher task; impact is limited to how quickly failures stop retrying if no override is configured.

Overview
Reduces the default UPLOAD_FINISHER_MAX_RETRIES in celery_config.py from 10 to 5, aligning upload finisher retry attempts with the upload processor unless explicitly overridden via config.

Written by Cursor Bugbot for commit ace1554. This will update automatically on new commits. Configure here.

@sentry
Copy link
Contributor

sentry bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (362d7b3) to head (ace1554).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1305     1305              
  Lines       47967    47981      +14     
  Branches     1636     1636              
==========================================
+ Hits        44252    44263      +11     
- Misses       3404     3407       +3     
  Partials      311      311              
Flag Coverage Δ
apiunit 96.35% <ø> (+<0.01%) ⬆️
sharedintegration 36.92% <ø> (-0.01%) ⬇️
sharedunit 84.89% <ø> (-0.02%) ⬇️
workerintegration 58.56% <ø> (ø)
workerunit 90.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 21, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing th/retries-to-5 (ace1554) with main (b82b927)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (5e5ae87) during the generation of this report, so b82b927 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant