fix: move upload finisher retries to 5#778
Closed
thomasrockhu-codecov wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 1305 1305
Lines 47967 47981 +14
Branches 1636 1636
==========================================
+ Hits 44252 44263 +11
- Misses 3404 3407 +3
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential reason why things are breaking on production. Backing this down to 5 to see if that's the case
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Low risk configuration tweak that only changes the default retry behavior for the upload finisher task; impact is limited to how quickly failures stop retrying if no override is configured.
Overview
Reduces the default
UPLOAD_FINISHER_MAX_RETRIESincelery_config.pyfrom 10 to 5, aligning upload finisher retry attempts with the upload processor unless explicitly overridden via config.Written by Cursor Bugbot for commit ace1554. This will update automatically on new commits. Configure here.