This repository was archived by the owner on May 5, 2025. It is now read-only.
fix(ta): pass right arg to cache rollup task#1223
Closed
joseph-sentry wants to merge 2 commits intomainfrom
Closed
fix(ta): pass right arg to cache rollup task#1223joseph-sentry wants to merge 2 commits intomainfrom
joseph-sentry wants to merge 2 commits intomainfrom
Conversation
we made the switch from repoid to repo_id previously but i failed to update the calls in CacheRollupCron and the new TA finisher also the call to process flakes in the new TA finisher no longer requires the commit id arg
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Swatinem
approved these changes
Apr 25, 2025
Contributor
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
lgtm, though tests are failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we made the switch from repoid to repo_id previously but i failed to update the calls in CacheRollupCron and the new TA finisher
also the call to process flakes in the new TA finisher no longer requires the commit id arg