-
Notifications
You must be signed in to change notification settings - Fork 165
feat: Migrate CommandBar HelpHub SDK for Documentation Site #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
"[CI] Staging environment is at https://staging-docs.codefresh.io/CR-33021/docs/" |
| {% if page.layout != "home" %} | ||
| <button | ||
| onclick="window.CommandBar.openHelpHub(); setTimeout(() => { | ||
| document.querySelector('input[data-testid=helphub-input]').focus() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the search input has a focused state by default when you open the amplitude's guides and surveys.
olegt-codefresh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove all HelpHub references and related code from the following files:
- assets/scss/_variables.scss
- assets/scss/_helpbub.scss
- README.md
olegt-codefresh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before pushing this change, we need to check how it will work for both Enterprise and GitOps segments.
Because Amplitude does not enabled segmentation, GitOps segment users will see results from the Enterprise segment.
| return; | ||
| } | ||
|
|
||
| window.amplitude.init(API_KEY, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I investigated this and found that userId is an optional parameter for this function. Amplitude automatically generates a unique deviceId and persists it in local storage, so a new user is not created each time the docs site is opened. In my opinion, this is an ideal out-of-the-box solution for our docs site.
|
"[CI] Staging environment is at https://staging-docs.codefresh.io/CR-33021/docs/" |
…gration