fix: a simple runtime application ends up being out-of-sync #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor redis.server configuration in argo-gateway and event-reporter configmaps to conditionally include the redis server URL only if it exists. Update tests to check for the absence of redis.server instead of its value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
make sure the
redis.serverconfigMap value is not rendered, if there is no value (instead of being rendered withnull)Refactor redis.server configuration in argo-gateway and event-reporter configmaps to conditionally include the redis server URL only if it exists. Update tests to check for the absence of redis.server instead of its value.
Why
when it is being rendered with
null, the cluster drops the key, and argo-cd sees a diff between desired and actual state. the ui shows a wrong diff (with"") due to golang diff code.Notes