fix: escape CSP nonce attributes in JSON responses #9938
Merged
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
the
bug
paulbalandan
reviewed
Feb 9, 2026
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
paulbalandan
approved these changes
Feb 10, 2026
datamweb
approved these changes
Feb 10, 2026
Member
Author
|
Thank you @paulbalandan and @datamweb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where
ContentSecurityPolicy::generateNonces()could corrupt the JSON response body.The method now detects
application/jsonContent-Type responses and properly escapes double quotes in nonce attribute replacements, preventing malformed JSON.Fixes #9934
Checklist: