Remove unused private helpers and make SpotBugs UPM warnings fail the quality check #4394

shai-almog · 2026-01-10T15:25:14Z

Motivation

Clear SpotBugs "Private method is never called" (UPM) findings by removing unused private helper methods across several UI, layout, graphics and IO classes.
Prevent regressions by treating the SpotBugs rule UPM_UNCALLED_PRIVATE_METHOD as a forbidden violation so future occurrences will fail the quality gate.

Description

Removed unused private helper methods from the following modules: CacheMap, Display, Graphics, LinearGradientPaint, TextSelection, URLImage, GeneralPath, LayeredLayout, LayoutStyle, CodenameOneMiGComponentWrapper, MigLayout, Border, UIManager, and SpinnerNode (15 files updated).
Commented out or deleted small, clearly-unused private methods and helpers to silence UPM warnings and keep code paths intact for runtime behavior.
Updated the quality enforcement script .github/scripts/generate-quality-report.py to add UPM_UNCALLED_PRIVATE_METHOD to the forbidden_rules set so SpotBugs UPM findings will cause the build to fail.
Created a single commit containing the code removals and the quality-report script change.

Testing

No automated tests were executed as part of this change; CI will exercise the changes and will now fail if SpotBugs reports UPM_UNCALLED_PRIVATE_METHOD violations.

Codex Task

shai-almog · 2026-01-10T15:38:39Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.53% (2629/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.24% (12248/50528), branch 15.22% (711/4672), complexity 17.31% (734/4241), method 32.58% (593/1820), class 34.32% (104/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.53% (2629/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.24% (12248/50528), branch 15.22% (711/4672), complexity 17.31% (734/4241), method 32.58% (593/1820), class 34.32% (104/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

shai-almog · 2026-01-10T15:49:57Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 273 seconds
Compilation Time: 102 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	24568 ms
Extract Extensions	19 ms
Google Services Setup	2 ms
Scan Classes	447 ms
Extract Libs	1012 ms
Inject Build Hints	31 ms
Generate Unit Tests	1 ms
Generate Stubs	805 ms
Compile Stubs	2020 ms
Generate Icons	998 ms
Prepare ParparVM	185 ms
ParparVM Execution	162109 ms
Post-VM Setup	131 ms
CocoaPods	4661 ms
Finalize	14 ms
Total Time	197004 msMaven Overhead : 76000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	62000 ms
App Install	15000 ms
App Launch	8000 ms
Test Execution	183000 ms

github-actions · 2026-01-10T18:30:04Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2282 total, 0 failed, 0 skipped
📊 Line coverage: 52.88% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

❌ SpotBugs: 172 findings (Normal: 107, Low: 65) [HTML preview] [Download]
- Top findings
  - Normal: CodenameOne/src/com/codename1/capture/Capture.java:262 – Naked notify (rule: NN_NAKED_NOTIFY)
  - Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:489 – Integral division result cast to double or float (rule: ICAST_IDIV_CAST_TO_DOUBLE)
  - Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:682 – Return value of method without side effect is ignored (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
  - Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:770 – Return value of method without side effect is ignored (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
  - Normal: CodenameOne/src/com/codename1/charts/compat/Paint.java:38 – Unused field (rule: UUF_UNUSED_FIELD)
  - …and 167 more
❌ PMD: 2574 findings (P2: 1, P3: 503, P4: 2070) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1040 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/components/RSSReader.java:500 – Overriding method merely calls super (rule: UselessOverridingMethod)
  - P3: CodenameOne/src/com/codename1/facebook/Album.java:198 – Overriding method merely calls super (rule: UselessOverridingMethod)
  - P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1312 – Unnecessary semicolon (rule: UnnecessarySemicolon)
  - …and 2569 more
❌ Checkstyle: 220822 findings (Warning: 220822) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220817 more

Generated automatically by the PR CI workflow.

…thod-warnings

Remove unused private helpers and enforce SpotBugs rule

d02edfa

shai-almog added the codex label Jan 10, 2026 — with ChatGPT Codex Connector

shai-almog added 3 commits January 10, 2026 19:47

Remove leftover unused helpers flagged by SpotBugs

e980c9b

Avoid SpotBugs UPM in HTMLComponent and MigLayout

6c0951d

Remove unused MigLayout constrain helper

2a24784

Merge branch 'master' into codex/fix-spotbugs-upm_uncalled_private_me…

e2918a0

…thod-warnings

shai-almog force-pushed the codex/fix-spotbugs-upm_uncalled_private_method-warnings branch from d892c32 to 48afb71 Compare January 10, 2026 19:01

Removed unused methods

9e9d4a2

shai-almog force-pushed the codex/fix-spotbugs-upm_uncalled_private_method-warnings branch from 48afb71 to 9e9d4a2 Compare January 11, 2026 02:33

shai-almog merged commit 77c3e9a into master Jan 11, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused private helpers and make SpotBugs UPM warnings fail the quality check #4394

Remove unused private helpers and make SpotBugs UPM warnings fail the quality check #4394

shai-almog commented Jan 10, 2026

Uh oh!

shai-almog commented Jan 10, 2026 •

edited

Loading

Uh oh!

shai-almog commented Jan 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove unused private helpers and make SpotBugs UPM warnings fail the quality check #4394

Remove unused private helpers and make SpotBugs UPM warnings fail the quality check #4394

Conversation

shai-almog commented Jan 10, 2026

Motivation

Description

Testing

Uh oh!

shai-almog commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Jan 10, 2026 •

edited

Loading

shai-almog commented Jan 10, 2026 •

edited

Loading

github-actions bot commented Jan 10, 2026 •

edited

Loading