Add @Concrete annotation and optimize ParparVM invoke resolution by liannacasper · Pull Request #4746 · codenameone/CodenameOne

liannacasper · 2026-04-14T06:37:37Z

Motivation

Provide a class-level hint that a base type maps to a known concrete implementation so the ParparVM translator can avoid virtual dispatch in native pipelines and produce faster C/Objective-C output.
Document the new hint in the performance guide to guide users about the tradeoffs and intended use.

Description

Add a new annotation com.codename1.annotations.Concrete with a name() element to declare a preferred concrete implementation for ParparVM translation.
Annotate CodenameOneImplementation with @Concrete(name = "com.codename1.impl.ios.IOSImplementation") to mark the platform implementation for native targets.
Extend ByteCodeClass with a concreteClass field and accessors (getConcreteClass/setConcreteClass) to hold the parsed concrete-class hint.
Update Parser to recognize the @Concrete annotation and store the name value (slash-separated) into the ByteCodeClass instance during class parsing.
Add resolution logic in CustomInvoke and Invoke so the translator attempts to bind virtual/virtual-like calls to the concrete class method owner (skipping virtual dispatch) when a concrete class is available and when not targeting the JavaScript backend; fall back to the original owner if no concrete implementation provides the method.
Update the performance documentation (performance.asciidoc) with a new section describing the @Concrete class-level hint and an example usage.

Testing

Ran the translator build and unit tests for the ByteCodeTranslator component; the build and unit tests completed successfully.
Performed a full project compile to ensure no regressions in the Java build; compilation succeeded.

Codex Task

github-actions · 2026-04-14T06:42:22Z

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

AsciiDoc linter: No issues found (report)
Vale: 14794 alert(s) (1056 errors, 4382 warnings, 9356 suggestions) (exit code 1) (report)
Image references: No unused images detected (report)

github-actions · 2026-04-14T06:46:24Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2379 total, 0 failed, 0 skipped
📊 Line coverage: 53.44% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 110 findings (High: 2, Normal: 81, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:647 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1808 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 107 more
- ❌ android: 414 findings (High: 24, Normal: 196, Low: 194)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 411 more
- ❌ codenameone-maven-plugin: 496 findings (High: 1, Normal: 319, Low: 176)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1020 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1045 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 493 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-04-14T06:52:13Z

Compared 37 screenshots: 37 matched.

Native Android coverage

📊 Line coverage: 7.78% (4095/52607 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.11% (20262/331632), branch 2.91% (930/31974), complexity 3.63% (1113/30630), method 6.38% (913/14308), class 10.58% (201/1899)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.78% (4095/52607 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.11% (20262/331632), branch 2.91% (930/31974), complexity 3.63% (1113/30630), method 6.38% (913/14308), class 10.58% (201/1899)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1754.000 ms
Base64 CN1 encode	150.000 ms
Base64 encode ratio (CN1/native)	0.086x (91.4% faster)
Base64 native decode	1506.000 ms
Base64 CN1 decode	169.000 ms
Base64 decode ratio (CN1/native)	0.112x (88.8% faster)

github-actions · 2026-04-14T07:13:53Z

✅ ByteCodeTranslator Quality Report

Test & Coverage

✅ Tests: 381 total, 0 failed, 2 skipped

Benchmark Results

Execution Time: 9259 ms
Hotspots (Top 20 sampled methods):
- 27.12% java.lang.String.indexOf (441 samples)
- 20.36% com.codename1.tools.translator.Parser.isMethodUsed (331 samples)
- 6.58% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (107 samples)
- 5.66% java.util.ArrayList.indexOf (92 samples)
- 5.23% java.lang.Object.hashCode (85 samples)
- 5.17% com.codename1.tools.translator.Parser.addToConstantPool (84 samples)
- 2.89% com.codename1.tools.translator.BytecodeMethod.optimize (47 samples)
- 2.64% java.lang.System.identityHashCode (43 samples)
- 2.09% com.codename1.tools.translator.ByteCodeClass.markDependent (34 samples)
- 1.78% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (29 samples)
- 1.60% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (26 samples)
- 1.48% com.codename1.tools.translator.BytecodeMethod.appendMethodSignatureSuffixFromDesc (24 samples)
- 0.74% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (12 samples)
- 0.68% com.codename1.tools.translator.Parser.cullMethods (11 samples)
- 0.68% com.codename1.tools.translator.BytecodeMethod.isMethodUsedByNative (11 samples)
- 0.62% com.codename1.tools.translator.ByteCodeClass.markDependencies (10 samples)
- 0.62% com.codename1.tools.translator.Parser.writeOutput (10 samples)
- 0.62% sun.nio.fs.UnixNativeDispatcher.open0 (10 samples)
- 0.62% java.lang.StringBuilder.append (10 samples)
- 0.49% com.codename1.tools.translator.Parser.getClassByName (8 samples)
⚠️ Coverage report not generated.

Static Analysis

✅ SpotBugs: no findings (report was not generated by the build).
⚠️ PMD report not generated.
⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

shai-almog · 2026-04-14T11:34:42Z

Compared 37 screenshots: 37 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 97 seconds

Detailed Performance Metrics

Metric	Duration
Simulator Boot	1000 ms
Simulator Boot (Run)	0 ms
App Install	2000 ms
App Launch	3000 ms
Test Execution	153000 ms
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	1626.000 ms
Base64 CN1 encode	1407.000 ms
Base64 encode ratio (CN1/native)	0.865x (13.5% faster)
Base64 native decode	733.000 ms
Base64 CN1 decode	1330.000 ms
Base64 decode ratio (CN1/native)	1.814x (81.4% slower)

Use /// docs for Concrete annotation

493851a

liannacasper added the codex label Apr 14, 2026 — with ChatGPT Codex Connector

Fix concrete invoke dependencies for generated headers

d73399c

liannacasper added 8 commits April 14, 2026 10:25

Only devirtualize to concrete class for declared methods

a39b12b

Skip concrete dispatch inside annotated base class internals

c5cd716

Fallback to base owner when invoke context is unavailable

9dd005e

Set instruction method context before dependency resolution

321fad1

Preserve base virtual dependencies with concrete call targets

802d37e

Gate concrete invoke devirtualization behind opt-in flag

1df80c6

Revert concrete invoke rewriting to restore stable dispatch

8f6a2ba

Re-enable concrete invoke optimization with strict ownership checks

49e47ea

liannacasper merged commit d9ae900 into master Apr 14, 2026
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add @Concrete annotation and optimize ParparVM invoke resolution#4746

Add @Concrete annotation and optimize ParparVM invoke resolution#4746
liannacasper merged 10 commits intomasterfrom
codex/add-concrete-annotation-to-codename-one

liannacasper commented Apr 14, 2026

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

liannacasper commented Apr 14, 2026

Motivation

Description

Testing

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ ByteCodeTranslator Quality Report

Test & Coverage

Benchmark Results

Static Analysis

Uh oh!

shai-almog commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

shai-almog commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

shai-almog commented Apr 14, 2026 •

edited

Loading