Skip to content

Fix/122 ci typecheck before tests#1

Open
Mela13076 wants to merge 5 commits into
mainfrom
fix/122-ci-typecheck-before-tests
Open

Fix/122 ci typecheck before tests#1
Mela13076 wants to merge 5 commits into
mainfrom
fix/122-ci-typecheck-before-tests

Conversation

@Mela13076
Copy link
Copy Markdown
Collaborator

Summary

  • The CI pipeline had a typecheck job configured but no dependency enforcement, meaning test-unit and test-integration ran in parallel with type checking rather than after it. This allowed type errors to slip through and surface as confusing test failures instead of clear mypy errors. This PR adds needs: [typecheck] to both test jobs so they are blocked until type checking passes, and also removes a stale pathreview/ directory reference from the mypy command that was causing a "cannot read file" error and preventing type checking from running at all.

Issue

Closes jamjamgobambam#122

Changes

  • Added needs: [typecheck] to test-unit job in .github/workflows/ci.yml
  • Added needs: [typecheck] to test-integration job in .github/workflows/ci.yml
  • Removed non-existent pathreview/ directory from the mypy command in .github/workflows/ci.yml
  • Removed same stale pathreview/ reference from make typecheck in Makefile

Testing

  • Unit tests pass (make test-unit)
  • Integration tests pass (make test-integration)
  • Linter passes (make lint)
  • Type checker passes (make typecheck)
  • New/updated tests cover the changes

Screenshots / Demo

Notes for Reviewers

  • The codebase currently has existing errors when testing. This PR does not fix them, it enforces that they can no longer be silently ignored in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI pipeline doesn't run type checks before tests, causing avoidable failures

1 participant