[WIP] generate a sharable image/png when copying#170
Draft
li-xin-yi wants to merge 1 commit intocodepod-io:mainfrom
Draft
[WIP] generate a sharable image/png when copying#170li-xin-yi wants to merge 1 commit intocodepod-io:mainfrom
li-xin-yi wants to merge 1 commit intocodepod-io:mainfrom
Conversation
Collaborator
Author
|
The API even works well with Python requests: I noticed that in no-CORS mode, the request type is opaque, so I can't get the response body (see this answer). I forced no-CORS mode because the hostname @lihebi Do you have any idea or suggestion with it? |
lihebi
reviewed
Dec 27, 2022
| }; | ||
| const res = await fetch("http://localhost:3099/api/cook", requesOptions); | ||
| const pic = await res.blob(); | ||
| // navigator.clipboard.write([new ClipboardItem({ "image/png": pic })]); |
Collaborator
lihebi
reviewed
Dec 27, 2022
| method: "POST", | ||
| headers: { "Content-Type": "application/json" }, | ||
| body: JSON.stringify({ code: pod.content }), | ||
| mode: "no-cors" as RequestMode, |
Collaborator
There was a problem hiding this comment.
CORS seems problematic. Let's add an Nginx route.
# nginx.conf
location /carbon {
rewrite ^/carbon(.*)$ $1 break;
proxy_pass http://carbon:3000;
}and in compose.yml, add a container:
carbon:
image: local/carbonara
The request URL will be http://localhost/carbon/api/cook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I use this API of carbon: https://github.com/petersolopov/carbonara
Notice that
localhostdoesn't allow CROS, we can't send a request ofapplication/jsonpayload tolocalhost:3099/api/cook, the actual request body is intext/plainformat. So you may need to skip the content type checking by deleting this line https://github.com/petersolopov/carbonara/blob/master/src/utils.js#L118, and then run the deployment command of this api by:To test if the api running normally, run a
cURLcommand:Now, the fetch request can be viewed with correct preview in devtools, I just wonder how to take it out.