feat: validate duplicate provider names in NewRequestBridge#240
Merged
ssncferreira merged 3 commits intomainfrom Mar 31, 2026
Merged
feat: validate duplicate provider names in NewRequestBridge#240ssncferreira merged 3 commits intomainfrom
ssncferreira merged 3 commits intomainfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 30, 2026
ssncferreira
commented
Mar 30, 2026
ssncferreira
force-pushed
the
ssncf/feat-validate-provider-names
branch
from
a55b2af to
d210136
Compare
ssncferreira
force-pushed
the
ssncf/fix-interceptor-provider
branch
from
15350e0 to
4a69340
Compare
ssncferreira
force-pushed
the
ssncf/feat-validate-provider-names
branch
from
d210136 to
e33dbcd
Compare
ssncferreira
requested review from
Copilot,
dannykopping and
pawbana
and removed request for
Copilot
ssncferreira
force-pushed
the
ssncf/feat-validate-provider-names
branch
2 times, most recently
from
71c69d3 to
30d306a
Compare
dannykopping
approved these changes
Mar 31, 2026
Collaborator
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
The timing for this is funny because I have to look into https://linear.app/codercom/issue/AIGOV-157/spike-to-understand-if-there-is-a-simple-way-to-handle-multi-api-key which may require multiple providers of the same name, but I'll have to find a way around this.
pawbana
approved these changes
Mar 31, 2026
Contributor
Author
Merge activity
|
ssncferreira
changed the base branch from
ssncf/fix-interceptor-provider
to
graphite-base/240
ssncferreira
force-pushed
the
ssncf/feat-validate-provider-names
branch
from
7d0c198 to
b1c6f3f
Compare
ssncferreira
added a commit
to coder/coder
that referenced
this pull request
Mar 31, 2026
… upstreams (#23811) ## Description Adds support for multiple Copilot provider instances to route requests to different Copilot upstreams (individual, business, enterprise). Each instance has its own name and base URL, enabling per-upstream metrics, logs, circuit breakers, API dump, and routing. ## Changes * Add Copilot business and enterprise provider names and host constants * Register three Copilot provider instances in aibridged (default, business, enterprise) * Update `defaultAIBridgeProvider` in `aibridgeproxy` to route new Copilot hosts to their corresponding providers ## Related * Depends on: coder/aibridge#240 * Closes: coder/aibridge#152 Note: documentation changes will be added in a follow-up PR. _Disclaimer: initially produced by Claude Opus 4.6, heavily modified and reviewed by @ssncferreira ._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds validation to
NewRequestBridgeto prevent registering multiple providers with the same name. Duplicate names would cause route prefix conflicts and ambiguous metrics, logs, and circuit breaker behavior.Changes
validateProviders()that rejects duplicate provider names at startupRelated to: #152
Disclaimer: initially produced by Claude Opus 4.6, heavily modified and reviewed by @ssncferreira .