Skip to content

Update Code to 1.113.0#7716

Merged
code-asher merged 3 commits intocoder:mainfrom
benz0li:code-1.113.0
Mar 26, 2026
Merged

Update Code to 1.113.0#7716
code-asher merged 3 commits intocoder:mainfrom
benz0li:code-1.113.0

Conversation

@benz0li
Copy link
Copy Markdown
Contributor

@benz0li benz0li commented Mar 25, 2026

No description provided.

@benz0li benz0li requested a review from a team as a code owner March 25, 2026 12:45
@benz0li
Copy link
Copy Markdown
Contributor Author

benz0li commented Mar 25, 2026

Ping @code-asher

...
[12:54:44] [mangler] ERROR: Protected fields have been made PUBLIC. This hurts minification and is therefore not allowed. Review the WARN messages further above
...

– https://github.com/coder/code-server/actions/runs/23541856157/job/68531271657?pr=7716#step:11:461

@code-asher
Fix another build failure
5ecc7aa
@code-asher
Use CI build targets
01734df 
The target we have been using has started throwing all sorts of errors
during the build (even without any of our patches).  After checking the
VS Code repo I think these are the ones we should actually be using.
They are way faster, too.
code-asher
code-asher approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@code-asher code-asher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at VS Code's GitHub workflows and it looks like they are using different build targets, so I tried those and it seems to be working.

Also these targets are way, way faster. 7.5-10 minutes instead of the hour+ it was before. Almost worried something must be wrong haha but I smoke tested it and everything seems to be working. Will probably make this one an RC first just in case.

@code-asher code-asher merged commit 8d9a44a into coder:main Mar 26, 2026
12 checks passed
@benz0li
Copy link
Copy Markdown
Contributor Author

benz0li commented Mar 26, 2026

Will probably make this one an RC first just in case.

Good idea.

@benz0li
Copy link
Copy Markdown
Contributor Author

benz0li commented Mar 26, 2026

@code-asher Please note the size increase, e.g.

  • code-server-4.112.0-linux-amd64.tar.gz: 122 MB
    vs
  • code-server-4.113.0-rc.1-linux-amd64.tar.gz: 234 MB

@code-asher
Copy link
Copy Markdown
Member

code-asher commented Mar 26, 2026 •
edited
Loading

Aha yup I noticed that too and investigated. They are including a few new dependencies, @github/copilot and some others that total to 132 MB (uncompressed).

The rest appears to be new files and source maps, but most of it seems to be those Copilot dependencies.

@code-asher
Copy link
Copy Markdown
Member

code-asher commented Mar 26, 2026

I think actually we can strip some of that out, looking at how VS Code is building things. I will mess around with that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benz0li @code-asher