Skip to content

fix: settings open makes window focus and in-front #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakehwll wants to merge 1 commit into from
Closed

fix: settings open makes window focus and in-front #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,5 +198,5 @@ extension AppDelegate {

@MainActor
func appActivate() {
NSApp.activate()
NSApp.activate(ignoringOtherApps: true)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep appActivate from stealing focus in background callbacks

Switching appActivate() to NSApp.activate(ignoringOtherApps: true) changes behavior for every caller, not only the Settings button. UpdaterService.updater(_:didFindValidUpdate:) invokes appActivate() when automatic update checks find a release, so this commit now forces the app to the foreground even if the user is actively working in another application. That makes background update discovery interruptive and is a regression in user experience outside the Settings flow.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

@jakehwll jakehwll Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm a fan of this, I think that if we're opening a window it makes genuine sense being the only way to access this is from the menubar.

Thoughts?

}
2 changes: 2 additions & 0 deletions Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ struct VPNMenu<VPN: VPNService, FS: FileSyncDaemon>: View {
}
AuthButton<VPN>()
Button {
NSApp.setActivationPolicy(.regular)
openSettings()
appActivate()
NSApp.arrangeInFront(nil)
} label: {
ButtonRowView { Text("Settings") }
}.buttonStyle(.plain)
Expand Down
Loading