Skip to content

feat: add .help() for workspace name #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakehwll wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add .help() for workspace name #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenuItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ struct MenuItemView: View {
return formattedName
}

private var fullItemName: String {
item.primaryHost(hostnameSuffix: state.hostnameSuffix)
}
Copy link
Copy Markdown
Member

@ethanndickson ethanndickson Mar 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace all references to item.primaryHost(hostnameSuffix: state.hostnameSuffix) elsewhere in this struct with fullItemName to avoid repeating ourselves?

Also, why full? itemName is already full. Maybe this should be plainItemName since itemName is the formatted/stylized one?


private var isExpanded: Bool {
expandedItem == item.id
}
Expand Down Expand Up @@ -134,6 +138,7 @@ struct MenuItemView: View {
.onHover { hovering in
nameIsSelected = hovering
}
.help(fullItemName)
}.buttonStyle(.plain).padding(.trailing, 3)
MenuItemIcons(item: item, wsURL: wsURL)
}
Expand Down
Loading