fix: mTLS certificate refresh #238
Open
+72
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A mechanism to intercept expired certificate errors was introduced in previous releases. Upon intercept the a command was spawend to refresh the certs and then the request was retried again. Unfortunately the interceptor mechanism had a big drawback, it only acts on an invalid response from the server. Most of the times the SSL handshake exceptions are raised much earlier, when the connection to the server is established. In this place the interceptor does not work. A different approach was instead used. All http calls are now wrapped in an executor that is able to retry the request if there is an exception in any of the request lifecycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mechanism to intercept expired certificate errors was introduced in previous releases. Upon intercept the a command was spawend to refresh the certs and then the request was retried again.
Unfortunately the interceptor mechanism had a big drawback, it only acts on an invalid response from the server. Most of the times the SSL handshake exceptions are raised much earlier, when the connection to the server is established. In this place the interceptor does not work.
A different approach was instead used. All http calls are now wrapped in an executor that is able to retry the request if there is an exception in any of the request lifecycle.