impl: remove support for data dir fallback setting

[fioan89]

This PR is a result of discussion that happened in the #286. Basically it as an attempt of simplifying the CLI resolution and trying to be more aligned with the VS Code extension. The existing implementation was too cumbersome to understand, brittle and a lot of tedious work needed to solve all of it's usecases.

This PR removes the enable fallback to data dir setting, which was used only for access denied exceptions. The CLI resolution uses the binary destination if it was configured by the user, or it automatically falls back to data dir if binary destination was not configured. The implementation respects the user's choice and no longer tries to make smart choices on behalf of the user. For example if the user configured the binary destination but disabled downloads we just prompt him with an error instead of trying to fall on data dir.

There were a couple of other small improvements left from the previous PR that are now addressed.

• resolves If coder is installed via winget, local binary fallback fails because plugin expects release artifact name instead of installed executable name #285

[fioan89]

[EhabY]

Code review

Found 1 issue:

1. prettify() uses this.message for AccessDeniedException and FileSystemException, which produces redundant error messages. FileSystemException.getMessage() returns a formatted string like "/path/to/file: Permission denied", so the output becomes "Access denied to /path/to/file: Permission denied". The existing humanizeConnectionError in Error.kt uses e.file instead (just the path), producing the cleaner "Access denied to /path/to/file.". Since the fallback is now removed and these exceptions will surface directly to users, consider using this.file (cast to FileSystemException) for both the AccessDeniedException and FileSystemException branches to stay consistent with the existing pattern.

coder-jetbrains-toolbox/src/main/kotlin/com/coder/toolbox/views/ErrorReporter.kt

Lines 64 to 69 in 43ab059

	} else this.message
	is AccessDeniedException,
	is java.nio.file.AccessDeniedException -> "Access denied to ${this.message}"
	is java.nio.file.FileSystemException -> "A file system operation failed when trying to access ${this.message}"

Existing pattern for reference:

coder-jetbrains-toolbox/src/main/kotlin/com/coder/toolbox/util/Error.kt

Lines 14 to 16 in 43ab059

	return when (e) {
	is java.nio.file.AccessDeniedException -> "Access denied to ${e.file}."
	is UnknownHostException -> "Unknown host ${e.message ?: deploymentURL.host}."

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[EhabY]

Honestly this is so straightforward compared to the previous approach!