Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a131cdb54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| className={cn( | ||
| LIST_ITEM_BASE_CLASSES, | ||
| "group/row", | ||
| sectionId != null ? "ml-8" : "ml-6.5", |
There was a problem hiding this comment.
This adds a fixed left margin to every workspace row when sectionId is present, but subagent connector positions are still derived only from depth-based padding (getItemPaddingLeft) in AgentListItemInner. In sectioned nested conversations, that means the row content (including the status dot/title) moves right while the connector overlay does not, so branch lines no longer connect to the corresponding row. The regression is visible whenever a section contains parent/child workspaces.
Useful? React with 👍 / 👎.
| className="min-w-0 flex-1 cursor-pointer truncate border-none bg-transparent p-0 text-left text-xs font-medium" | ||
| style={{ color: sectionColor }} | ||
| > |
There was a problem hiding this comment.
Using sectionColor directly for the section name text makes readability depend on arbitrary user-selected colors from the color picker. In light themes, pale colors (and in dark themes, very dark colors) can make section titles effectively illegible, whereas the previous styling kept text on a theme-safe foreground and used color as an accent. This should compute a contrast-safe foreground or constrain unsupported colors.
Useful? React with 👍 / 👎.
1 participant
No description provided.