fix: parse remote authority from right#944
Merged
Merged
Conversation
EhabY
force-pushed
the
fix/parse-remote-authority-safe-host
branch
2 times, most recently
from
7193197 to
b97c6e2
Compare
EhabY
force-pushed
the
fix/parse-remote-authority-safe-host
branch
from
b97c6e2 to
351582c
Compare
code-asher
approved these changes
May 12, 2026
- Combine authority/host-name format docs into the function docstring. - Use shorthand property names in the returned AuthorityParts. - Drop the over-strict empty-segment check; only fail when the safe hostname, username, or workspace/agent segment is empty so domains like foo---------------bar.com remain valid. - Add a regression test covering a safe hostname with many consecutive dashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #937.
Summary
--agentparser expectations; add double-dash/triple-dash safeHost regressions.Tests
pnpm test:extension ./test/unit/util.test.ts ./test/unit/core/pathResolver.test.ts ./test/unit/remote/sshConfig.test.tspnpm typecheckpnpm lintpnpm test:extensionpnpm format:checkImplementation notes (Coder Agents generated)
parseRemoteAuthoritynow requirescoder-vscode.<safeHost>and at least username/workspace fields.--segment as workspace/agent, the previous segment as username, and rejoins earlier segments as safeHost.--segments.Generated by Coder Agents.