Skip to content

feat: add experimental workspaces view#947

Open
jakehwll wants to merge 6 commits into
mainfrom
jakehwll/experimental-workspaces-view
Open

feat: add experimental workspaces view#947
jakehwll wants to merge 6 commits into
mainfrom
jakehwll/experimental-workspaces-view

Conversation

@jakehwll
Copy link
Copy Markdown
Contributor

@jakehwll jakehwll commented May 12, 2026

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

Scaffolds a new experimental Workspaces webview panel behind the coder.experimental.workspacesPanel setting, giving us a blank canvas to iterate on a redesigned workspaces experience. The feature is fully gated and hidden from the Settings UI so it won't affect existing users.

  • Adds a packages/workspaces package with a React + Vite + React Query entrypoint and Storybook support
  • Registers a new coderExperimentalWorkspaces activity bar view container ("Coder Remote (New)") visible only when the flag is enabled and the user is authenticated
  • Introduces ExperimentalWorkspacesPanelProvider implementing WebviewViewProvider with IPC dispatch scaffolding and deployment-change refresh wiring
  • Gates everything behind coder.experimental.workspacesPanel (boolean, default false) — sets the coder.experimental.webkitWorkspaces context key to control view visibility
  • Adds a coder.workspaces.refresh command for manual panel refresh

@jakehwll jakehwll requested a review from EhabY May 12, 2026 04:08
@jakehwll jakehwll marked this pull request as ready for review May 12, 2026 04:08
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4681d77d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/commandManager.ts Outdated
Comment thread src/webviews/workspaces/workspacesPanelProvider.ts Outdated
Comment thread packages/shared/src/workspaces/api.ts Outdated
Comment thread packages/workspaces/README.md
Comment thread packages/workspaces/README.md Outdated
Comment thread packages/workspaces/README.md Outdated
Comment on lines +26 to +27
> [!NOTE]
> The new view will only appear after you instantiate the Coder context (i.e clicking Tasks or Workspaces).
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I know why this exists, I do a similar hack for the Coder Tasks where we register a dummy empty view that shows the login button if it's not authenticated but show the webview when it is. Maybe we should do something like this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted — didn't add the login view pattern in this pass since it's more of a follow-up concern, but it's a good idea. Could be a separate PR once we flesh out the panel.

🤖 Generated with Coder Agents

Comment thread src/webviews/workspaces/workspacesPanelProvider.ts Outdated
Comment thread package.json Outdated
Comment thread src/webviews/workspaces/workspacesPanelProvider.ts Outdated
Comment thread src/webviews/workspaces/workspacesPanelProvider.ts Outdated
Comment thread src/webviews/workspaces/workspacesPanelProvider.ts Outdated
Comment thread src/webviews/workspaces/workspacesPanelProvider.ts Outdated
- Remove verbose comments from WorkspacesApi (api.ts)
- Remove setting definition from package.json (VS Code reads settings.json directly)
- Rename ExperimentalWorkspacesPanelProvider → WorkspacesPanelProvider
- Rename context key: coder.experimental.webkitWorkspaces → coder.workspacesPanelEnabled
- Remove unused client: CoderApi constructor param
- Use import type for Logger
- Tighten localResourceRoots to dist/webviews/workspaces
- Drop showErrorToUser (optional, matches chat panel pattern)
- Extract disposeView() helper to deduplicate cleanup logic
- Add else branch to log unexpected messages
- Use shorthand-logo.svg icon for view container
- Remove unnecessary comments from extension.ts registration
- Clean up README (remove fragile implementation details)
Copy link
Copy Markdown
Collaborator

@EhabY EhabY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! now we can iterate on this view without disrupting users

@EhabY EhabY self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants