feat: add experimental workspaces view#947
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4681d77d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…al-workspaces-view' into jakehwll/experimental-workspaces-view
| > [!NOTE] | ||
| > The new view will only appear after you instantiate the Coder context (i.e clicking Tasks or Workspaces). |
There was a problem hiding this comment.
I think I know why this exists, I do a similar hack for the Coder Tasks where we register a dummy empty view that shows the login button if it's not authenticated but show the webview when it is. Maybe we should do something like this?
There was a problem hiding this comment.
Noted — didn't add the login view pattern in this pass since it's more of a follow-up concern, but it's a good idea. Could be a separate PR once we flesh out the panel.
🤖 Generated with Coder Agents
- Remove verbose comments from WorkspacesApi (api.ts) - Remove setting definition from package.json (VS Code reads settings.json directly) - Rename ExperimentalWorkspacesPanelProvider → WorkspacesPanelProvider - Rename context key: coder.experimental.webkitWorkspaces → coder.workspacesPanelEnabled - Remove unused client: CoderApi constructor param - Use import type for Logger - Tighten localResourceRoots to dist/webviews/workspaces - Drop showErrorToUser (optional, matches chat panel pattern) - Extract disposeView() helper to deduplicate cleanup logic - Add else branch to log unexpected messages - Use shorthand-logo.svg icon for view container - Remove unnecessary comments from extension.ts registration - Clean up README (remove fragile implementation details)
EhabY
left a comment
There was a problem hiding this comment.
Nice! now we can iterate on this view without disrupting users
Scaffolds a new experimental Workspaces webview panel behind the
coder.experimental.workspacesPanelsetting, giving us a blank canvas to iterate on a redesigned workspaces experience. The feature is fully gated and hidden from the Settings UI so it won't affect existing users.packages/workspacespackage with a React + Vite + React Query entrypoint and Storybook supportcoderExperimentalWorkspacesactivity bar view container ("Coder Remote (New)") visible only when the flag is enabled and the user is authenticatedExperimentalWorkspacesPanelProviderimplementingWebviewViewProviderwith IPC dispatch scaffolding and deployment-change refresh wiringcoder.experimental.workspacesPanel(boolean, defaultfalse) — sets thecoder.experimental.webkitWorkspacescontext key to control view visibilitycoder.workspaces.refreshcommand for manual panel refresh