Skip to content

SANDBOX-1769 | feature: type for "enabled integrations" in the config#502

Open
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enable-integrations-ui-api
Open

SANDBOX-1769 | feature: type for "enabled integrations" in the config#502
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enable-integrations-ui-api

Conversation

@MikelAlejoBR
Copy link
Copy Markdown

@MikelAlejoBR MikelAlejoBR commented Apr 10, 2026

Description

We want to be able to control the integrations that are displayed in the UI via the ToolchainConfig, and in order to do that we need to have a field that controls which integrations are enbaled and which are not.

Related PRs

Jira ticket

[SANDBOX-1769]

Checks

  1. Did you run make generate target? yes/no

Yes.

  1. Did make generate change anything in other projects (host-operator, member-operator)? yes/no

Yes.

  1. In case of new CRD, did you the following? yes/no

It is not a new CRD, but rather a change in an existing one.

  1. In case other projects are changed, please provides PR links.

Will do as soon as I open them

Summary by CodeRabbit

  • New Features
    • Added optional configuration to control integration visibility in the UI. When specified, only the listed integrations are displayed; when unset or empty, all integrations remain enabled.

We want to be able to control the integrations that are displayed in the
UI via the ToolchainConfig, and in order to do that we need to have a
field that controls which integrations are enbaled and which are not.

SANDBOX-1769
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Walkthrough

A new optional configuration field enabledIntegrations of type string array is added to RegistrationServiceConfig. This field controls which integrations are visible or enabled in the UI, with nil or empty values treating all integrations as enabled. Updates span type definitions, API documentation, deepcopy implementations, and OpenAPI schema generation.

Changes

Cohort / File(s) Summary
Type Definition and Documentation
api/v1alpha1/toolchainconfig_types.go, api/v1alpha1/docs/apiref.adoc
Added EnabledIntegrations []string field to RegistrationServiceConfig struct with JSON annotation and documentation describing UI integration filtering behavior.
Generated Code
api/v1alpha1/zz_generated.deepcopy.go, api/v1alpha1/zz_generated.openapi.go
Updated deepcopy logic to handle the new field via slice allocation and copy, and added corresponding OpenAPI schema property with x-kubernetes-list-type: set vendor extension.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a type/field for 'enabled integrations' configuration in ToolchainConfig.
Description check ✅ Passed PR description covers main objectives, provides Jira ticket, and includes all required checklist items with appropriate responses.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants