Skip to content

Ignore spaces when verifying DKIM entry #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jschornick wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

Ignore spaces when verifying DKIM entry #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mxroute_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ def command_dkim(domains):
dns_data = make_api_request(DNS_CMD, {'domain': domain })
dkim_data = next((item for item in dns_data['records'] if item.get('name') == DKIM_SUB), None)
if dkim_data:
dkim_data = dkim_data['value']
dkim_data = dkim_data[1:len(dkim_data)-1]
dkim_data = dkim_data['value'].strip('"').replace(' ','')

# Now test if it matches by looking up the live value on DNS
# pip3 install dnspython
Expand All @@ -160,7 +159,7 @@ def command_dkim(domains):
try:
dns_lookup = dns.resolver.resolve(f"{DKIM_SUB}.{domain}", 'TXT')[0]
for txt_string in dns_lookup.strings:
dkim_in_dns = dkim_in_dns + txt_string.decode('utf-8')
dkim_in_dns = dkim_in_dns + txt_string.decode('utf-8').replace(' ','')
except Exception:
dkim_in_dns = 'NONE'

Expand Down