Outline/shadow element decorations and video element crop/rounded corners#2378
Open
tf wants to merge 12 commits intocodevise:masterfrom
Open
Outline/shadow element decorations and video element crop/rounded corners#2378tf wants to merge 12 commits intocodevise:masterfrom
tf wants to merge 12 commits intocodevise:masterfrom
Conversation
Label hue and opacity range inputs so screen readers can announce them. ColorPicker now reads translations directly via I18n. REDMINE-21248
Allow style types to configure color picker behavior like alpha support and swatches via inputOptions. REDMINE-21248
Allow content elements to opt into box shadow and outline decoration effects via the supportedStyles mechanism. Themes can configure a box shadow scale similar to the existing margin scale. REDMINE-21248
Move the decoration_effects feature check from StylesCollection into Style.getEffectTypes so that decoration effect types are excluded before they reach the collection. This lets StylesCollection stay agnostic of feature flags. This allows giving content element styles kind property to group styles in list. REDMINE-21248
Extract shared attribute binding logic into reusable utils so that style types can declare a binding condition. When a bound attribute (e.g. a poster image) is not set, the corresponding style option is hidden in the unused styles list and displayed as unavailable with inert controls when already applied. REDMINE-21248
REDMINE-21248
REDMINE-21248
REDMINE-21248
REDMINE-21248
Allow applying crop and rounded corner effects to inline video elements, including orientation-specific variants for portrait video files. REDMINE-21248
The bottom border on the last group creates a visual artifact since there is no following group to separate from. REDMINE-21248
tf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21248