Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Jan 21, 2026

closes #1100

Additionally, this PR improves the vote summary's list responsiveness to variable device screen widths:

ssr-2026-01-21_05.04.55.mp4

@Oaphi Oaphi requested review from a team, cellio and trichoplax January 21, 2026 02:08
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (072a25c) to head (a4b758d).

Additional details and impacted files
Components Coverage Δ
controllers 74.70% <ø> (ø)
helpers 84.91% <ø> (ø)
jobs 80.59% <ø> (ø)
models 90.09% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cellio
Copy link
Member

cellio commented Jan 22, 2026

This is much better! I was about to say "works for me" when I stumbled over a weird edge case.

Here is a page with a browser width of 600:

looks good

And here is that page just a smidge smaller (594):

original behavior

I'm not sure exactly where in that 6-pixel range it's happening (I'm adjusting window sizes by hand here and using a "how wide am I?" tool to get the values).

If this is really just some weirdness in an extreme edge case, I don't want to block on it. But I wonder why it happens and if anything else behaves oddly for just a few pixels.

@Oaphi
Copy link
Member Author

Oaphi commented Jan 22, 2026

I'm not sure exactly where in that 6-pixel range it's happening (I'm adjusting window sizes by hand here and using a "how wide am I?" tool to get the values).

I was worried something like this would happen - our grid is actually a flexbox with flex-wrap set to wrap which, even with the fix, leads to weirdness like this. Let's switch to a proper grid layout - setting the PR in "draft" mode for now

@Oaphi Oaphi marked this pull request as draft January 22, 2026 23:55
@cellio
Copy link
Member

cellio commented Jan 23, 2026

It's better than it was, but I couldn't figure out the cause and implications of this weirdness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badges on vote summary page are misaligned

3 participants