You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hm... is there an advantage for us to extend the parser instead of more closely defining the diff output?
Yeah, this is a good open question.
The reason I went with parser-side is that relint also supports --diff, where the diff comes from stdin.
In that mode, relint cannot control how git diff was invoked, so a user (like me) piping output from Git with diff.mnemonicPrefix=true / other custom prefixes would still hit the same parser issue.
We can force prefixes, but it will only fix own relint's calls. As long as we want to support git diff and all documented non-default prefixes, we'd need to deal with the parser extension...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git diff headers may use prefixes other than
a/andb/, for example, whendiff.mnemonicPrefix=trueis configured:diff --git c/file.py i/file.pyRelint now parses diff headers with arbitrary non-empty prefixes, so both
--diffand--git-diffkeep working with mnemonic/custom prefixes.I added parser-level coverage and an integration regression test for
--git-diffwithdiff.mnemonicPrefix=true.Other references: