chore(moonwell): remove leftover DEBUG console.error calls#1271
Open
memosr wants to merge 1 commit into
Open
Conversation
Two console.error("DEBUG - ...") statements were left in the mint and
redeem catch blocks of moonwellActionProvider.ts. The errors are already
returned to the caller as strings, so these were pure debug noise.
Library code that calls console.error pollutes stdout/stderr in agent
runtimes and can surface raw on-chain error details that the caller
already handled. Removed both lines without touching the surrounding
error-return logic.
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two leftover
console.error("DEBUG - ...")statements frommoonwellActionProvider.tsthat appear to be debug artifacts.The issue
In
typescript/agentkit/src/action-providers/moonwell/moonwellActionProvider.ts:Line 172 (inside
mintcatch block):Line 268 (inside
redeemcatch block):The "DEBUG -" prefix is a strong tell that these are dev-loop leftovers. The errors are already returned to the caller as descriptive strings, so the
console.errorcalls add nothing — they only:The fix
Removed both
console.errorlines. The surrounding catch logic that returns the error string to the caller is untouched.} catch (error) { - console.error("DEBUG - Mint error:", error); return `Error minting tokens: ${error}`; }} catch (error) { - console.error("DEBUG - Redeem error:", error); return `Error redeeming tokens: ${error}`; }Verification
moonwellActionProvider.tsmodified