docs: use https:// for GitHub link in create-onchain-agent READMEs#1277
Open
memosr wants to merge 1 commit into
Open
docs: use https:// for GitHub link in create-onchain-agent READMEs#1277memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
Both create-onchain-agent README files (TypeScript and Python) linked to the AgentKit repo via http://github.com. GitHub has required HTTPS since 2020, so the HTTP URL triggers an immediate redirect and some corporate proxies, link checkers, and security scanners flag http://github.com as insecure. Updated the URL and the link text in both files.
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both create-onchain-agent README files (TypeScript and Python) link to the AgentKit GitHub repo via
http://github.cominstead ofhttps://github.com.Changes
typescript/create-onchain-agent/README.md(line 66):python/create-onchain-agent/README.md(line 91):Why it matters
GitHub has required HTTPS since 2018, so the HTTP URL works only via an immediate 301 redirect. Beyond the redirect cost:
http://github.comas insecurehttp://external links in documentation entirelyhttp://link sets a bad example for users learning to build onchain agentsVerification