Skip to content

docs: use https:// for GitHub link in create-onchain-agent READMEs#1277

Open
memosr wants to merge 1 commit into
coinbase:mainfrom
memosr:fix/create-onchain-agent-https
Open

docs: use https:// for GitHub link in create-onchain-agent READMEs#1277
memosr wants to merge 1 commit into
coinbase:mainfrom
memosr:fix/create-onchain-agent-https

Conversation

@memosr
Copy link
Copy Markdown

@memosr memosr commented Jun 4, 2026

Summary

Both create-onchain-agent README files (TypeScript and Python) link to the AgentKit GitHub repo via http://github.com instead of https://github.com.

Changes

typescript/create-onchain-agent/README.md (line 66):

- - **GitHub Repo:** [http://github.com/coinbase/agentkit](http://github.com/coinbase/agentkit)
+ - **GitHub Repo:** [https://github.com/coinbase/agentkit](https://github.com/coinbase/agentkit)

python/create-onchain-agent/README.md (line 91):

- - **GitHub Repo:** [http://github.com/coinbase/agentkit](http://github.com/coinbase/agentkit)
+ - **GitHub Repo:** [https://github.com/coinbase/agentkit](https://github.com/coinbase/agentkit)

Why it matters

GitHub has required HTTPS since 2018, so the HTTP URL works only via an immediate 301 redirect. Beyond the redirect cost:

  • Corporate proxies and link checkers often flag http://github.com as insecure
  • Some security scanners block http:// external links in documentation entirely
  • The http:// link sets a bad example for users learning to build onchain agents

Verification

  • ✅ Only 2 README files modified
  • ✅ Both the link label and the URL updated in each file
  • ✅ No other content touched

Both create-onchain-agent README files (TypeScript and Python) linked to
the AgentKit repo via http://github.com. GitHub has required HTTPS since
2020, so the HTTP URL triggers an immediate redirect and some corporate
proxies, link checkers, and security scanners flag http://github.com as
insecure.

Updated the URL and the link text in both files.
@memosr memosr requested a review from murrlincoln as a code owner June 4, 2026 17:42
@cb-heimdall
Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

2 participants