-
-
Notifications
You must be signed in to change notification settings - Fork 323
Feature/ add a tag(--body-length-limit) for command commit #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yjaw
wants to merge
8
commits into
commitizen-tools:master
Choose a base branch
from
yjaw:feature/commit-line-limt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−5
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aa15fda
feat(commit): add a tag(--body-length-limit) and a function for comma…
yjaw 1f74bb2
test(commit): add some test for commit --body-length-limit flag
yjaw faacc87
refactor(commit): refactor test case and logic for tag --body-length-…
yjaw 071e450
refactor(commit): rewrite logic and test for tag: --body-length-limit…
yjaw 005b422
fix(commit): add default value for --body-length-tag in the cli.py an…
yjaw f514bdd
refactor(commit): refactor code and test follow by suggestions
yjaw 3dc5471
fix(commit): fix some code and test according to suggestions
yjaw f17a654
fix(commit): resolve conflicts with upstream master
yjaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ | |
| import shutil | ||
| import subprocess | ||
| import tempfile | ||
| import textwrap | ||
| from itertools import chain | ||
| from pathlib import Path | ||
| from typing import TYPE_CHECKING, TypedDict | ||
|
|
||
|
|
@@ -36,6 +38,7 @@ class CommitArgs(TypedDict, total=False): | |
| edit: bool | ||
| extra_cli_args: str | ||
| message_length_limit: int | ||
| body_length_limit: int | ||
| no_retry: bool | ||
| signoff: bool | ||
| write_message_to_file: Path | None | ||
|
|
@@ -82,6 +85,7 @@ def _get_message_by_prompt_commit_questions(self) -> str: | |
|
|
||
| message = self.cz.message(answers) | ||
| self._validate_subject_length(message) | ||
| message = self._wrap_body(message) | ||
| return message | ||
|
|
||
| def _validate_subject_length(self, message: str) -> None: | ||
|
|
@@ -100,6 +104,28 @@ def _validate_subject_length(self, message: str) -> None: | |
| f"Length of commit message exceeds limit ({len(subject)}/{message_length_limit}), subject: '{subject}'" | ||
| ) | ||
|
|
||
| def _wrap_body(self, message: str) -> str: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a docstring explaining what this |
||
| """ | ||
| Wrap the body of the commit message to the --body-length-limit length. | ||
| """ | ||
|
|
||
| body_length_limit = self.arguments.get( | ||
| "body_length_limit", self.config.settings["body_length_limit"] | ||
| ) | ||
| # By the contract, body_length_limit is set to 0 for no limit | ||
| if not body_length_limit or body_length_limit <= 0: | ||
| return message | ||
|
|
||
| lines = message.split("\n") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like |
||
| if len(lines) < 3: | ||
| return message | ||
|
|
||
| # First line is subject, second is blank line, rest are body lines | ||
| wrapped_body_lines = chain.from_iterable( | ||
| textwrap.wrap(line, width=body_length_limit) for line in lines[2:] | ||
| ) | ||
| return "\n".join(chain(lines[:2], wrapped_body_lines)) | ||
|
|
||
| def manual_edit(self, message: str) -> str: | ||
| editor = git.get_core_editor() | ||
| if editor is None: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
tests/commands/test_commit_command/test_commit_command_body_length_limit_disabled_.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| feat: add feature | ||
|
|
||
| This is a very long line that exceeds 72 characters and should NOT be wrapped when body_length_limit is set to 0 |
1 change: 1 addition & 0 deletions
1
tests/commands/test_commit_command/test_commit_command_body_length_limit_no_body_.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| feat: add feature |
5 changes: 5 additions & 0 deletions
5
...ands/test_commit_command/test_commit_command_body_length_limit_preserves_line_breaks_.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| feat: add feature | ||
|
|
||
| Line1 is shorter than the limit but has newline | ||
| Line2 is shorter than the limit but has newline | ||
| Line3 is shorter than the limit but has newline |
4 changes: 4 additions & 0 deletions
4
tests/commands/test_commit_command/test_commit_command_body_length_limit_wrapping_.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| feat: add feature | ||
|
|
||
| This is a very long line that exceeds 72 characters and should be | ||
| automatically wrapped by the system to fit within the limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can set a default value here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. What’s the difference between setting a default value here and using default_setting in defaults.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think
DEFAULT_SETTINGSis not a good design. I am not sure the mechanism of default value inargparse, not sure the exact difference here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally the default should be in DEFAULT_SETTINGS, which can be updated from the .cz.toml file. A default in argparse may override the setting in the file. You can add a test, to check that this is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that multiple default setting is undesirable. Should I remove the default setting for this tag from
cli.py?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after a second look, there should not be default values in cli.py because we want cz to use the settings from the configuration file if the value is None in arguments