Refactor: Use O(1) dereferencing for string emptiness checks instead of strlen()#613
Merged
Merged
Conversation
Member
|
This makes sense to me, thanks. @nwellnhof any objections? |
Contributor
|
Looks good to me. Unrelated, but you have to check errno after calling strtol to detect invalid and out-of-range numbers reliably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
strlen(str) > 0to check for empty strings incurs an unnecessary O(N) cost, especially inside node rendering functions where it might be called repeatedly.Checking the first character
str[0]is the idiomatic C approach for an O(1) emptiness check.This PR updates
src/commonmark.candsrc/main.cto use this safer and more performant approach, preventing potential performance bottlenecks on large documents with extensive attributes.