Skip to content

BCH-1295: Add resource_arn label for e2e assert.sh compatibility#2

Merged
saltpy-cs merged 1 commit into
masterfrom
feat/basic-eks-coverage
Jun 11, 2026
Merged

BCH-1295: Add resource_arn label for e2e assert.sh compatibility#2
saltpy-cs merged 1 commit into
masterfrom
feat/basic-eks-coverage

Conversation

@saltpy-cs

Copy link
Copy Markdown
Contributor

Summary

  • Add resource_arn label to cluster, nodegroup, and addon evidence contexts in internal/evidence.go
  • Required by local-dev/e2e/lib/assert.sh which matches evidence to Terraform output ARNs via $labels.resource_arn == $arn
  • ECR plugin already sets this label; EKS plugin was missing it, which would cause all e2e assertions to fail

Test plan

  • All existing unit tests pass (go test ./... — 2 packages, 0 failures)
  • Manually verified label map contains resource_arn matching the type-specific ARN field for cluster, nodegroup, and addon

🤖 Generated with Claude Code

…dence

Required by assert.sh which filters evidence by $labels.resource_arn == $arn
to match against Terraform output ARN values.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@saltpy-cs, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 59 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f5717b9b-0918-403e-8e19-8690ef5dd92d

📥 Commits

Reviewing files that changed from the base of the PR and between 5a1707b and d72cfa0.

📒 Files selected for processing (1)
  • internal/evidence.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saltpy-cs saltpy-cs merged commit fc3e4d2 into master Jun 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant