Skip to content

Fix missing closing quote on --annotate flag in gooci upload steps#3

Merged
saltpy-cs merged 1 commit into
masterfrom
feat/basic-eks-coverage
Jun 11, 2026
Merged

Fix missing closing quote on --annotate flag in gooci upload steps#3
saltpy-cs merged 1 commit into
masterfrom
feat/basic-eks-coverage

Conversation

@saltpy-cs

@saltpy-cs saltpy-cs commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes an unexpected EOF shell error during gooci upload caused by missing closing " on the --annotate flag in both upload steps.

Test plan

  • Re-trigger the release workflow and confirm the gooci upload steps complete without the EOF error

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed artifact publishing process to ensure release artifacts are correctly annotated with version metadata during the build pipeline.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4d7dd9da-d2d5-42e6-bcc6-872c753a25f2

📥 Commits

Reviewing files that changed from the base of the PR and between fc3e4d2 and dae5c04.

📒 Files selected for processing (1)
  • .github/workflows/build-and-upload.yml

📝 Walkthrough

Walkthrough

The pull request fixes the quoting syntax of the --annotate flag in the gooci upload command within the build-and-upload workflow. The versioned artifact upload now has correctly formed annotation argument quoting, and the latest artifact upload follows the same corrected format while remaining guarded by the prerelease condition.

Changes

Build and Upload Workflow

Layer / File(s) Summary
gooci upload annotation flag quoting
.github/workflows/build-and-upload.yml
The --annotate="org.ccf.plugin.protocol.version=2" flag for the versioned artifact upload is corrected with proper shell quoting, and the latest artifact upload aligns with the same annotation format while maintaining its prerelease condition guard.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A tiny quote fixed in the night,
--annotate now quoted right,
gooci commands flow with care,
Shell escapes floating in the air,
Details matter, large and small,
Precision wins through them all! 🐰


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saltpy-cs saltpy-cs merged commit bd83c7c into master Jun 11, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant