Skip to content

Fix nil bootstrap_creator_admin_permissions treated as truthy by OPA #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saltpy-cs merged 1 commit into from
Jun 11, 2026
Merged

Fix nil bootstrap_creator_admin_permissions treated as truthy by OPA #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,14 @@ func clusterAuthenticationMode(cluster types.Cluster) string {
return string(cluster.AccessConfig.AuthenticationMode)
}

func clusterBootstrapCreatorAdminPermissions(cluster types.Cluster) *bool {
func clusterBootstrapCreatorAdminPermissions(cluster types.Cluster) bool {
if cluster.AccessConfig == nil {
return nil
return false
}
if cluster.AccessConfig.BootstrapClusterCreatorAdminPermissions == nil {
return false
}
return cluster.AccessConfig.BootstrapClusterCreatorAdminPermissions
return *cluster.AccessConfig.BootstrapClusterCreatorAdminPermissions
}

func clusterSecretsEncryptionConfigured(cluster types.Cluster) bool {
Expand Down
Loading