fix: unblock release CI (bootstrapRun complexity, stale gate tests)

[pedronauck]

Summary

main (commit 8cc8ff39) is red, blocking the v0.0.6 release PR #248. All three failing release-PR checks trace back to main, not the release branch:

• Verify — internal/daemon/coordinator_runtime.go bootstrapRun exceeded the gocyclo threshold (CC 21 > 20). Extracted reconcileCreatedCoordinator and wakeCoordinatorIfNeeded — a behavior-preserving split that drops complexity to ~10.
• Integration — TestHarnessContextIntegrationStartupAndPromptShareResolverPolicy counted <agh-situation-context> (the open tag), which the bundled tools guide (tools-and-skills.md) documents in prose, so the count was 2. It now counts the closing </agh-situation-context> tag → measures rendered sections (exactly 1). The product already renders the section once; the assertion was fragile (red since v0.0.5).
• E2E Nightly — the sandbox "real session execution" test direct-navigates to a session created in a temp workspace while the global workspace is active. fix: persist active workspace and redirect on session/workspace mismatch #238's useSessionWorkspaceGuard redirects away on a workspace/session mismatch, so the composer never rendered and locator.fill hit the 180s timeout. The test now activates the session's workspace via the switcher first — the persisted-active-workspace precondition fix: persist active workspace and redirect on session/workspace mismatch #238 assumes for direct navigation.

Verification

• make verify — pass (full monorepo gate).
• golangci-lint v2.12.2 ./... (CI's pinned version) — 0 issues.
• go test -race ./internal/daemon/... — 875 unit pass; 987 integration pass (-tags integration).
• bun-lint — 0 warnings / 0 errors; web typecheck — pass.
• The E2E fix is verified by deterministic root-cause analysis + typecheck/lint; the release PR's E2E Nightly lane (the lane that failed) is its end-to-end gate. A faithful single-test local run is blocked by the nightly coverage-gate plus the daemon-served harness env.

Release impact

Merging this refreshes release/v0.0.6 (#248) to include the fix so its Verify and Integration lanes go green. Version stays v0.0.6 — CI's pinned git-cliff 2.7.0 treats feat: as a patch bump on 0.x (same as how v0.0.5 was cut).

Note: v0.0.5's own release PR (#237) merged with Integration + Verify failing. The heavy lanes (Integration, E2E Nightly) only run on release PRs, so these regressions slipped past per-feature CI. Worth tightening the merge gate separately.

AGH Impact Audit:

• Native tools: no impact — no agh__* IDs, toolsets, descriptors, input/output schemas, schema digests, risk flags, or capability gates changed; this is an internal daemon refactor plus two test files.
• Extensibility and hooks: no impact — no extension manifests/resources, hook taxonomy or dispatch call sites, skill/capability declarations, bundles, registries, bridge SDKs, MCP sidecars, or config.toml lifecycle changed. bootstrapRun's dispatch call sites, locking, and ordering are preserved by the extraction.
• Workspace data isolation: no impact on runtime data ownership — the coordinator refactor preserves workspace_id-scoped bootstrap/reconcile/dispatch exactly; the e2e change only makes the test honor the existing per-workspace session-route guard from fix: persist active workspace and redirect on session/workspace mismatch #238.
• Official AGH skill: no impact — skills/agh/SKILL.md and skills/agh/references/*.md are unchanged. The tools-and-skills.md <agh-situation-context> mention is correct documentation and intentionally left as-is; the test was corrected instead.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor

  • Improved internal coordinator session initialization and management code organization for better maintainability and clarity.

• Tests

  • Updated integration tests with refined assertions to better validate rendered output correctness.
  • Enhanced end-to-end tests with explicit verification steps for workspace-to-session binding workflows.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agh-site	Ready	Preview, Comment	Jun 2, 2026 7:34pm

[github-actions]

No React Doctor issues found in this scan.

Score	Issues	Errors	Warnings	Affected Files	Scope
100 / 100 (Great)	0	0	0	0	3 files changed on fix/release-v006-unblock-lint-tests vs. main

View workflow run

Generated by React Doctor. Questions? Contact founders@million.dev.

[coderabbitai]

Walkthrough

Refactored coordinator session bootstrapping to extract wake-prompt behavior into a reusable helper (wakeCoordinatorIfNeeded) and consolidate created-session reconciliation into a dedicated function (reconcileCreatedCoordinator). The reconciliation function acquires locks, detects duplicate coordinators, and propagates wake errors via caller-side dispatch. Updated integration and e2e tests to validate proper reconciliation and workspace context setup.

Changes

Coordinator Session Bootstrapping and Workspace Resolution

Layer / File(s)	Summary
Wake coordinator helper extraction internal/daemon/coordinator_runtime.go	The existing-coordinator wake path in bootstrapRun delegates prompting to wakeCoordinatorIfNeeded, which encapsulates the begin/finish lifecycle and returns prompt errors for caller-side dispatch instead of performing inline dispatch.
Reconciliation helper implementation internal/daemon/coordinator_runtime.go	bootstrapRun delegates created-coordinator singleton reconciliation to reconcileCreatedCoordinator. That function acquires a lock, performs workspace singleton resolution, detects and handles existing duplicates, calls wakeCoordinatorIfNeeded for wake prompting with error propagation, and dispatches the winning session's lifecycle decision.
Test updates validating reconciliation behavior internal/daemon/harness_context_integration_test.go, web/e2e/__tests__/sandbox.spec.ts	Integration test updates situation-context rendering assertion to count closing tags for accurate instance validation. E2E test adds explicit workspace-switcher interaction to activate session workspace before navigating to the session route, ensuring proper workspace context setup.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• compozy/agh#240: Coordinator wake reliability changes in the same runtime code paths affected by this refactoring.

Suggested labels

release-pending, automated

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main purpose: unblocking release CI by fixing bootstrapRun complexity and stale gate tests, which aligns with the three core changes (refactoring, integration test fix, and e2e test adjustment).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/release-v006-unblock-lint-tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

internal/daemon/coordinator_runtime.go (1)

403-421: 💤 Low value

Consider using defer to guarantee cleanup.

The finishCoordinatorWake call is duplicated in both the error and success paths. Using defer would simplify the code and ensure cleanup cannot be accidentally bypassed in future modifications.

♻️ Proposed simplification using defer

 func (r *coordinatorRuntime) wakeCoordinatorIfNeeded(
 	ctx context.Context,
 	target *session.Info,
 	decision coordinator.Decision,
 	reason string,
 	shouldPrompt bool,
 ) error {
 	if !shouldPrompt {
 		return nil
 	}
-	if err := r.promptCoordinator(ctx, target, decision, reason); err != nil {
-		r.finishCoordinatorWake(target, decision)
-		return err
-	}
-	r.finishCoordinatorWake(target, decision)
-	return nil
+	defer r.finishCoordinatorWake(target, decision)
+	return r.promptCoordinator(ctx, target, decision, reason)
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/daemon/coordinator_runtime.go` around lines 403 - 421, The
wakeCoordinatorIfNeeded function duplicates r.finishCoordinatorWake in both
branches; change it to call r.finishCoordinatorWake(target, decision) via defer
immediately after the shouldPrompt check so cleanup always runs (e.g., after
verifying shouldPrompt, add defer r.finishCoordinatorWake(target, decision) and
then call r.promptCoordinator(ctx, target, decision, reason)); keep the existing
error return behavior from promptCoordinator unchanged and ensure the defer uses
the same target and decision variables passed into wakeCoordinatorIfNeeded.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@internal/daemon/coordinator_runtime.go`:
- Around line 403-421: The wakeCoordinatorIfNeeded function duplicates
r.finishCoordinatorWake in both branches; change it to call
r.finishCoordinatorWake(target, decision) via defer immediately after the
shouldPrompt check so cleanup always runs (e.g., after verifying shouldPrompt,
add defer r.finishCoordinatorWake(target, decision) and then call
r.promptCoordinator(ctx, target, decision, reason)); keep the existing error
return behavior from promptCoordinator unchanged and ensure the defer uses the
same target and decision variables passed into wakeCoordinatorIfNeeded.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4f3fc0eb-10cc-4e16-989a-b7f5f294110b

📥 Commits

Reviewing files that changed from the base of the PR and between 8cc8ff3 and 37956fa.

📒 Files selected for processing (3)

• internal/daemon/coordinator_runtime.go
• internal/daemon/harness_context_integration_test.go
• web/e2e/__tests__/sandbox.spec.ts