refactor: improvements on create modals#252
Open
pedronauck wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (10)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR simplifies the pre-commit hook by removing react-doctor staged-scan logic and adds three new daemon lifecycle Make targets ( ChangesDeveloper Tooling Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
React Doctor found 64 issues in 31 files.
Top Findings
Generated by React Doctor. Questions? Contact founders@million.dev. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Makefile (1)
120-122: ⚡ Quick winAvoid masking real failures in
restartstop phase.
$(MAKE) stop || truesuppresses every stop error, including unexpected ones. Prefer ignoring only the expected “not running” case so real shutdown failures are visible.Suggested adjustment
restart: - @$(MAKE) stop || true + @./bin/agh daemon stop || { \ + code=$$?; \ + echo "daemon stop failed (exit $$code)"; \ + exit $$code; \ + } @$(MAKE) start🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 120 - 122, The restart target currently silences all failures from the stop phase with `$(MAKE) stop || true`; change it to run the stop target, capture its exit status and output, and only suppress the error when the stop failure corresponds to the expected "not running" case; otherwise propagate the error. Concretely, update the restart recipe (the restart target) to run `$(MAKE) stop`, save its exit code/output, check the output or code for the specific "not running" indicator (or expected exit code) and only continue to `$(MAKE) start` when that indicator is present—if not, re-exit with the original stop exit code so real shutdown failures are visible. Ensure you reference the restart target and the stop target names when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Makefile`:
- Around line 120-122: The restart target currently silences all failures from
the stop phase with `$(MAKE) stop || true`; change it to run the stop target,
capture its exit status and output, and only suppress the error when the stop
failure corresponds to the expected "not running" case; otherwise propagate the
error. Concretely, update the restart recipe (the restart target) to run
`$(MAKE) stop`, save its exit code/output, check the output or code for the
specific "not running" indicator (or expected exit code) and only continue to
`$(MAKE) start` when that indicator is present—if not, re-exit with the original
stop exit code so real shutdown failures are visible. Ensure you reference the
restart target and the stop target names when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac9e5a56-b7a2-4780-935e-d057dc98f70e
⛔ Files ignored due to path filters (94)
.agents/skills/impeccable/SKILL.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/agents/impeccable_asset_producer.tomlis excluded by!**/*.toml,!.agents/**.agents/skills/impeccable/agents/impeccable_manual_edit_applier.tomlis excluded by!**/*.toml,!.agents/**.agents/skills/impeccable/agents/openai.yamlis excluded by!**/*.yaml,!.agents/**.agents/skills/impeccable/reference/adapt.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/animate.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/audit.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/bolder.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/brand.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/clarify.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/codex.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/cognitive-load.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/color-and-contrast.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/colorize.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/craft.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/critique.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/delight.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/distill.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/document.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/extract.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/harden.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/heuristics-scoring.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/init.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/interaction-design.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/layout.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/live.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/motion-design.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/onboard.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/optimize.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/overdrive.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/personas.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/polish.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/product.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/quieter.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/responsive-design.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/shape.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/spatial-design.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/teach.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/typeset.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/typography.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/reference/ux-writing.mdis excluded by!**/*.md,!.agents/**.agents/skills/impeccable/scripts/cleanup-deprecated.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/command-metadata.jsonis excluded by!**/*.json,!.agents/**.agents/skills/impeccable/scripts/context-signals.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/context.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/design-parser.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/browser/injected/index.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/cli/main.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/detect-antipatterns-browser.jsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/detect-antipatterns.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/engines/browser/detect-url.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/engines/regex/detect-text.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/engines/static-html/css-cascade.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/engines/static-html/detect-html.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/engines/visual/screenshot-contrast.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/findings.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/node/file-system.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/profile/profiler.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/registry/antipatterns.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/rules/checks.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/shared/color.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/shared/constants.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/detector/shared/page.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/impeccable-paths.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-accept.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-browser.jsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-commit-manual-edits.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-completion.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-copy-edit-agent.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-discard-manual-edits.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-event-validation.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-inject.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-insert-ui.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-insert.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-manual-edit-evidence.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-manual-edits-buffer.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-poll.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-resume.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-server.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-session-store.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-status.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-svelte-component.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-sveltekit-adapter.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-ui-core.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live-wrap.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/live.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/load-context.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/palette.mjsis excluded by!.agents/**.agents/skills/impeccable/scripts/pin.mjsis excluded by!.agents/**DESIGN.mdis excluded by!**/*.mddocs/design/opendesign/trigger-create-redesign.htmlis excluded by!docs/design/**/*openapi/agh.jsonis excluded by!**/*.jsonskills-lock.jsonis excluded by!**/*.jsonweb/src/generated/agh-openapi.d.tsis excluded by!**/generated/**
📒 Files selected for processing (155)
.husky/pre-commitMakefileinternal/api/contract/scheduler.gointernal/api/core/tasks_surface_test.gointernal/api/core/tasks_test.gointernal/api/spec/spec.gointernal/api/spec/spec_test.gointernal/e2elane/pre_commit_hook_test.gointernal/store/globaldb/global_db_task_claim_test.gointernal/store/globaldb/global_db_task_pause.gointernal/task/types.gointernal/task/validate.gopackages/ui/src/tokens.cssweb/src/components/choice-card.tsxweb/src/hooks/routes/__tests__/use-app-layout.test.tsxweb/src/hooks/routes/__tests__/use-home-page.test.tsxweb/src/hooks/routes/__tests__/use-tasks-page.test.tsxweb/src/hooks/routes/__tests__/workspace-scope-filter.test.tsweb/src/hooks/routes/use-app-layout.tsweb/src/hooks/routes/use-automation-page.tsweb/src/hooks/routes/use-home-page.tsweb/src/hooks/routes/use-task-create-route-state.tsweb/src/hooks/routes/use-tasks-page.tsweb/src/hooks/routes/workspace-scope-filter.tsweb/src/routes/__tests__/-_app.test.tsxweb/src/routes/_app/__tests__/-jobs-triggers.integration.test.tsxweb/src/routes/_app/__tests__/-tasks.new.test.tsxweb/src/routes/_app/__tests__/-tasks.router.integration.test.tsxweb/src/routes/_app/__tests__/-tasks.test.tsxweb/src/routes/_app/stories/-index.stories.tsxweb/src/routes/_app/tasks.$id.edit.tsxweb/src/routes/_app/tasks.new.tsxweb/src/routes/_app/tasks.tsxweb/src/storybook/__tests__/msw.test.tsweb/src/storybook/__tests__/web-storybook-msw-contract.test.tsweb/src/storybook/msw.tsweb/src/storybook/route-story.tsxweb/src/systems/agent/hooks/use-agents.tsweb/src/systems/automation/components/__tests__/automation-editor-dialog.test.tsxweb/src/systems/automation/components/__tests__/automation-job-form.test.tsxweb/src/systems/automation/components/__tests__/automation-trigger-form.test.tsxweb/src/systems/automation/components/automation-detail-panel.tsxweb/src/systems/automation/components/automation-editor-dialog.tsxweb/src/systems/automation/components/automation-job-form.tsxweb/src/systems/automation/components/automation-trigger-form.tsxweb/src/systems/automation/components/job-form/agent-run-step.tsxweb/src/systems/automation/components/job-form/cron-builder.tsxweb/src/systems/automation/components/job-form/output-mode.tsxweb/src/systems/automation/components/job-form/preview/job-preview.tsxweb/src/systems/automation/components/job-form/preview/next-runs-card.tsxweb/src/systems/automation/components/job-form/preview/payload-card.tsxweb/src/systems/automation/components/job-form/preview/run-digest-card.tsxweb/src/systems/automation/components/job-form/preview/summary-card.tsxweb/src/systems/automation/components/job-form/reliability-section.tsxweb/src/systems/automation/components/job-form/schedule-at.tsxweb/src/systems/automation/components/job-form/schedule-every.tsxweb/src/systems/automation/components/job-form/scope-step.tsxweb/src/systems/automation/components/job-form/task-run-step.tsxweb/src/systems/automation/components/stories/automation-editor-dialog.stories.tsxweb/src/systems/automation/components/stories/automation-job-form.stories.tsxweb/src/systems/automation/components/stories/automation-trigger-form.stories.tsxweb/src/systems/automation/components/stories/job-form/cron-builder.stories.tsxweb/src/systems/automation/components/stories/job-form/job-preview.stories.tsxweb/src/systems/automation/components/stories/trigger-form/event-catalog.stories.tsxweb/src/systems/automation/components/stories/trigger-form/filter-conditions.stories.tsxweb/src/systems/automation/components/stories/trigger-form/trigger-preview.stories.tsxweb/src/systems/automation/components/trigger-form/agent-prompt-step.tsxweb/src/systems/automation/components/trigger-form/event-card.tsxweb/src/systems/automation/components/trigger-form/event-catalog.tsxweb/src/systems/automation/components/trigger-form/event-sub-config.tsxweb/src/systems/automation/components/trigger-form/filter-conditions.tsxweb/src/systems/automation/components/trigger-form/filter-row.tsxweb/src/systems/automation/components/trigger-form/flow-step.tsxweb/src/systems/automation/components/trigger-form/preview/preview-card.tsxweb/src/systems/automation/components/trigger-form/preview/preview-summary.tsxweb/src/systems/automation/components/trigger-form/preview/rendered-prompt.tsxweb/src/systems/automation/components/trigger-form/preview/sample-event-card.tsxweb/src/systems/automation/components/trigger-form/preview/trigger-preview.tsxweb/src/systems/automation/components/trigger-form/preview/webhook-endpoint-card.tsxweb/src/systems/automation/components/trigger-form/prompt-template-field.tsxweb/src/systems/automation/components/trigger-form/reliability-section.tsxweb/src/systems/automation/components/trigger-form/scope-step.tsxweb/src/systems/automation/components/trigger-form/variable-bar.tsxweb/src/systems/automation/hooks/use-automation-job-form.tsweb/src/systems/automation/hooks/use-automation-trigger-form.tsweb/src/systems/automation/lib/__tests__/automation-drafts.test.tsweb/src/systems/automation/lib/__tests__/cron-engine.test.tsweb/src/systems/automation/lib/__tests__/trigger-preview.test.tsweb/src/systems/automation/lib/automation-drafts.tsweb/src/systems/automation/lib/cron-engine.tsweb/src/systems/automation/lib/job-preview.tsweb/src/systems/automation/lib/trigger-catalog.tsweb/src/systems/automation/lib/trigger-event-id.tsweb/src/systems/automation/lib/trigger-preview.tsweb/src/systems/automation/lib/trigger-template.tsweb/src/systems/onboarding/mocks/fixtures.tsweb/src/systems/onboarding/mocks/handlers.tsweb/src/systems/onboarding/mocks/index.tsweb/src/systems/runtime/components/__tests__/app-sidebar.test.tsxweb/src/systems/runtime/components/app-sidebar.tsxweb/src/systems/runtime/components/stories/app-sidebar.stories.tsxweb/src/systems/runtime/hooks/__tests__/nav-counts-default-fetchers.test.tsweb/src/systems/runtime/hooks/nav-counts-store.tsweb/src/systems/scheduler/adapters/scheduler-api.tsweb/src/systems/scheduler/lib/query-keys.tsweb/src/systems/tasks/components/__tests__/task-card.test.tsxweb/src/systems/tasks/components/__tests__/task-editor-modal.test.tsxweb/src/systems/tasks/components/__tests__/tasks-list-row.test.tsxweb/src/systems/tasks/components/__tests__/tasks-list-surface.test.tsxweb/src/systems/tasks/components/stories/task-editor-modal.stories.tsxweb/src/systems/tasks/components/stories/task-form/mode-toolbar.stories.tsxweb/src/systems/tasks/components/stories/task-form/template-cards.stories.tsxweb/src/systems/tasks/components/stories/tasks-list-row.stories.tsxweb/src/systems/tasks/components/stories/tasks-list-surface.stories.tsxweb/src/systems/tasks/components/task-card.tsxweb/src/systems/tasks/components/task-editor-modal.tsxweb/src/systems/tasks/components/task-form/contract-section.tsxweb/src/systems/tasks/components/task-form/execution-collapsible.tsxweb/src/systems/tasks/components/task-form/ingress-identity-section.tsxweb/src/systems/tasks/components/task-form/mode-toolbar.tsxweb/src/systems/tasks/components/task-form/numbered-section.tsxweb/src/systems/tasks/components/task-form/placement-section.tsxweb/src/systems/tasks/components/task-form/priority-section.tsxweb/src/systems/tasks/components/task-form/queue-ownership-section.tsxweb/src/systems/tasks/components/task-form/template-cards.tsxweb/src/systems/tasks/components/task-group.tsxweb/src/systems/tasks/components/tasks-list-filters.tsxweb/src/systems/tasks/components/tasks-list-row.tsxweb/src/systems/tasks/components/tasks-list-surface.tsxweb/src/systems/tasks/components/use-tasks-create-modal-form.tsweb/src/systems/tasks/index.tsweb/src/systems/tasks/lib/__tests__/task-editor.test.tsweb/src/systems/tasks/lib/__tests__/task-grouping.test.tsweb/src/systems/tasks/lib/__tests__/tasks-list-filters.test.tsweb/src/systems/tasks/lib/task-editor.tsweb/src/systems/tasks/lib/task-grouping.tsweb/src/systems/tasks/lib/task-templates.tsweb/src/systems/tasks/lib/tasks-list-filters.tsweb/src/systems/workspace/components/__tests__/scope-selector.test.tsxweb/src/systems/workspace/components/__tests__/workspace-command-select.test.tsxweb/src/systems/workspace/components/scope-selector.tsxweb/src/systems/workspace/components/stories/scope-selector.stories.tsxweb/src/systems/workspace/components/stories/workspace-command-select.stories.tsxweb/src/systems/workspace/components/workspace-command-select.tsxweb/src/systems/workspace/contexts/scope-selector-context-value.tsweb/src/systems/workspace/contexts/scope-selector-context.tsxweb/src/systems/workspace/hooks/use-scope-selector-context.tsweb/src/systems/workspace/hooks/use-sync-user-home-dir.tsweb/src/systems/workspace/hooks/use-user-home-dir-store.tsweb/src/systems/workspace/hooks/use-user-home-dir.tsweb/src/systems/workspace/index.tsweb/src/systems/workspace/lib/__tests__/workspace-command-select-options.test.tsweb/src/systems/workspace/lib/home-workspace.tsweb/src/systems/workspace/lib/workspace-command-select-options.tsweb/src/systems/workspace/stores/user-home-dir-store.ts
💤 Files with no reviewable changes (1)
- .husky/pre-commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
make start(builds and launches daemon),make stop, andmake restartfor convenient service control.Chores