Add live test coverage: Tiers 1-3 + next-tier (~80 new commands)#3280
Open
Daniel Ayaz (danielayaz) wants to merge 3 commits intomainfrom
Open
Add live test coverage: Tiers 1-3 + next-tier (~80 new commands)#3280Daniel Ayaz (danielayaz) wants to merge 3 commits intomainfrom
Daniel Ayaz (danielayaz) wants to merge 3 commits intomainfrom
Conversation
…additional commands Tier 1 (read-only, zero infra): organization, audit-log, service-quota, billing, kafka region, context/configuration commands. Tier 2 (standard cloud IAM & kafka): iam user, ip-group/filter CRUD, identity provider/pool/group-mapping CRUD, certificate-authority/pool CRUD, kafka quota CRUD, kafka produce/consume. Tier 3 (connect & SR extensions): connect custom-plugin list, schema-registry cluster describe, compatibility validate, subject update. Also adds live-test-billing Makefile target and updates live-test-essential to include billing. All 14 new resources added to live-test-resource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
Adds a new set of live integration tests (tiered by feature area) and Makefile conveniences to run them by group/resource, expanding end-to-end coverage of CLI commands across core, kafka, IAM, connect, schema registry, and billing.
Changes:
- Add 14 new
test/live/*_live_test.gofiles covering additional CLI command areas (list/describe + selected CRUD). - Extend
make live-test-essential, addmake live-test-billing, and register new resources inmake live-test-resource. - Add schema-registry/connect/IAM extended live flows (schema compatibility validation, identity provider/pool/group-mapping, certificate authority/pool).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/live/service_quota_live_test.go | Adds live test for service-quota list. |
| test/live/schema_registry_extended_live_test.go | Adds extended SR live flow (cluster describe, schema create, compat validate, subject update, config describe, cleanup). |
| test/live/organization_live_test.go | Adds live tests for organization list/describe with JSON assertions. |
| test/live/kafka_region_live_test.go | Adds live tests for kafka region list across clouds. |
| test/live/kafka_quota_live_test.go | Adds live CRUD test for kafka quotas including SA creation and cleanup. |
| test/live/kafka_produce_consume_live_test.go | Adds produce/consume live test + consumer group list + client-config create. |
| test/live/iam_user_live_test.go | Adds live tests for IAM user list + invitation list. |
| test/live/iam_ip_group_filter_live_test.go | Adds IAM IP group/filter CRUD live coverage with verification steps. |
| test/live/iam_identity_provider_live_test.go | Adds IAM provider/pool/group-mapping live CRUD coverage. |
| test/live/iam_certificate_live_test.go | Adds IAM certificate authority/pool live CRUD coverage (self-signed cert generation). |
| test/live/context_live_test.go | Adds live tests for context/configuration commands and configuration update. |
| test/live/connect_extended_live_test.go | Adds connect custom-plugin live test scaffold. |
| test/live/billing_live_test.go | Adds live tests for billing price/cost/promo list commands. |
| test/live/audit_log_live_test.go | Adds live tests for audit-log describe + route list. |
| Makefile | Adds billing live-test target, includes billing in essential set, and registers new resources for live-test-resource. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+21
to
+23
| // Register cleanup | ||
| s.registerCleanup(t, "connect custom-plugin delete {{.plugin_id}} --force", state) | ||
|
|
| "testing" | ||
| ) | ||
|
|
||
| func (s *CLILiveTestSuite) TestConnectCustomPluginCRUDLive() { |
Comment on lines
+30
to
+31
| Name: "Describe disable_updates config", | ||
| Args: "configuration describe disable_updates -o json", |
| // Group Mapping CRUD | ||
| { | ||
| Name: "Create group mapping", | ||
| Args: `iam group-mapping create ` + groupMappingName + ` --description "Live test group mapping" --filter "\"engineering\" in groups" -o json`, |
| // Certificate Pool CRUD (depends on authority) | ||
| { | ||
| Name: "Create certificate pool", | ||
| Args: `iam certificate-pool create --provider {{.cert_authority_id}} --display-name "live-test-pool" --description "Live test certificate pool" --external-identifier "OU=Engineering" --filter "certificate.subject == \"OU=Engineering\"" -o json`, |
…connect offsets/events, billing payment, SR endpoint Batch A (read-only): flink region list (aws/gcp/azure), plugin list, kafka share-group list, billing payment describe, schema-registry endpoint list, connect custom-runtime list. Batch B (connect lifecycle): connect offset describe, connect event describe piggybacking on existing connector in TestConnectClusterCRUDLive. Adds live-test-flink Makefile target and flink_region, plugin, kafka_share_group resources. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Daniel Ayaz (danielayaz)
changed the title
Daniel Ayaz (danielayaz)
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Expands live test coverage from ~50 commands to ~130 commands across Confluent Cloud commands. This is a test-only PR — no production code is modified.
Coverage Summary
Changes
Tiers 1-3 (14 new test files, ~70 commands):
Next-tier wins (3 new test files, ~10 more commands):
flink region list(aws/gcp/azure) — newflinkbuild tag andlive-test-flinkMakefile targetplugin list— local-only, no cloud dependencykafka share-group list— requires existing clusterbilling payment describe— read-only addition to existing billing testschema-registry endpoint list— read-only addition to existing SR extended testconnect custom-runtime list— read-only addition to existing connect extended testconnect offset describe/connect event describe— piggyback on existing connector lifecycle inTestConnectClusterCRUDLiveMakefile updates:
live-test-flinktargetlive-test-billingtarget, updatedlive-test-essentialto include billinglive-test-resource(flink_region, plugin, kafka_share_group + 14 from Tiers 1-3)Blast Radius
Zero customer impact. This PR only adds live test files and Makefile targets. No production CLI code is changed.
References
Test & Review
go vet -tags="live_test,all"andgo vet -tags="live_test,flink"with no errors.make live-test-resourceprints all 28 resources correctly.make live-test-resource RESOURCE=<name>(requires CI environment withCLI_LIVE_TEST=1and appropriate env vars).