Run the linter and unit tests on a pull request.#137
Closed
tim-vk wants to merge 2 commits intocontainerbuildsystem:masterfrom
Closed
Run the linter and unit tests on a pull request.#137tim-vk wants to merge 2 commits intocontainerbuildsystem:masterfrom
tim-vk wants to merge 2 commits intocontainerbuildsystem:masterfrom
Conversation
Signed-off-by: Tim van Katwijk <timvankatwijk@hotmail.com>
Signed-off-by: Tim van Katwijk <timvankatwijk@hotmail.com>
tim-vk
force-pushed
the
feature/linter_on_PR
branch
from
9f0f678 to
11a990c
Compare
tim-vk
changed the title
Member
|
how is this different from what we already have? CIs are already running when you create PR, reason why some steps didn't run for your previous PR is unknown but I'd say there was something up with the actions |
Contributor
Author
|
Hmm... odd I figured this would be the issue since my other PR also has actions that didn't run (here). But When checking other (older) pr's it seems you are right. Apolagies! |
Member
Contributor
Author
|
I saw! Awsome that you double checked it. I closed this PR. Given the discussion in PR #129 I think I'll make a new branch (& PR) and close that one. |
Member
|
you can just reuse branch & pr you have, for sake of conversation in that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since my previous PR created linter errors on master & release_*:
Both linter & unittests now run on pull requests.
Unittests only run on changed .py file.
Linter always runs
Maintainers will complete the following section