test: refactor compose_pull_linux_test.go to use nerdtest/tigron#4796
Open
juannio wants to merge 1 commit intocontainerd:mainfrom
Open
test: refactor compose_pull_linux_test.go to use nerdtest/tigron#4796juannio wants to merge 1 commit intocontainerd:mainfrom
juannio wants to merge 1 commit intocontainerd:mainfrom
Conversation
juannio
force-pushed
the
issues-4613-migrate-compose-pull-tests
branch
from
eed1666 to
61fcc6c
Compare
haytok
reviewed
Mar 17, 2026
Member
haytok
left a comment
haytok
left a comment
There was a problem hiding this comment.
Thanks for creating this PR! Could you check when you have time?
| comp := testutil.NewComposeDir(t, dockerComposeYAML) | ||
| defer comp.CleanUp() | ||
| projectName := comp.ProjectName() | ||
| t.Logf("projectName=%q", projectName) |
Member
There was a problem hiding this comment.
Please display projectName in the log.
Comment on lines
+77
to
+81
| testCase.Cleanup = func(data test.Data, helpers test.Helpers) { | ||
| if data.Labels().Get("composeYAML") != "" { | ||
| helpers.Anyhow("rmi", data.Labels().Get("mariaDBImage")) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Which part of the original implementation does this process correspond to?
Author
There was a problem hiding this comment.
Good catch, this wasn't in the original implementation. I added it based on patterns I saw in other migrated tests, but since this is a straightforward migration I'll keep it faithful to the original. Removed, thanks!
Signed-off-by: juannio <juaniorosas.99@gmail.com>
juannio
force-pushed
the
issues-4613-migrate-compose-pull-tests
branch
from
61fcc6c to
667c894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests to use nerdtest.Setup and the Tigron testing framework as per issue #4613