virtio/fs: report actual bytes written in used ring len#701
Open
cathay4t wants to merge 1 commit into
Open
Conversation
The virtio used ring's len field must reflect the number of bytes the device wrote into the writable descriptor chain. libkrun was hard-coding 0, which broke FUSE protocol validation added in Linux kernel commit 68b69fa0edb (virtiofs: add FUSE protocol validation). Resolves: containers#695 Signed-off-by: Gris Ge <cnfourt@gmail.com>
cathay4t
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
Author
|
Manually tested by and confirmed podman krun works well with kernel 7.1 rc5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtio used ring's len field must reflect the number of bytes the
device wrote into the writable descriptor chain. libkrun was hard-coding
0, which broke FUSE protocol validation added in Linux kernel commit
68b69fa0edb (virtiofs: add FUSE protocol validation).
Resolves: #695