Skip to content

fix: Do not miss freeing pointers on error #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmathern merged 2 commits into from
Jun 2, 2026
Merged

fix: Do not miss freeing pointers on error #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e6461
fix: Do not miss freeing pointers on error
tmathern Jun 2, 2026
8ca39b1
Merge branch 'main' into mathern/error-leak-fix
tmathern Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions src/c2pa/c2pa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,7 +1425,12 @@ def __init__(self):
super().__init__()

ptr = _lib.c2pa_settings_new()
_check_ffi_operation_result(ptr, "Failed to create Settings")
try:
_check_ffi_operation_result(ptr, "Failed to create Settings")
except Exception:
if ptr:
ManagedResource._free_native_ptr(ptr)
raise

self._handle = ptr
self._lifecycle_state = LifecycleState.ACTIVE
Expand Down Expand Up @@ -2403,11 +2408,16 @@ def _init_from_context(self, context, format_or_path,
reader_ptr = _lib.c2pa_reader_from_context(
context.execution_context,
)
_check_ffi_operation_result(reader_ptr,
Reader._ERROR_MESSAGES[
'reader_error'
].format("Unknown error")
)
try:
_check_ffi_operation_result(reader_ptr,
Reader._ERROR_MESSAGES[
'reader_error'
].format("Unknown error")
)
except Exception:
if reader_ptr:
ManagedResource._free_native_ptr(reader_ptr)
raise

if manifest_data is not None:
if not isinstance(manifest_data, bytes):
Expand Down Expand Up @@ -3176,11 +3186,16 @@ def _init_from_context(self, context, json_str):
builder_ptr = _lib.c2pa_builder_from_context(
context.execution_context,
)
_check_ffi_operation_result(builder_ptr,
Builder._ERROR_MESSAGES[
'builder_error'
].format("Unknown error")
)
try:
_check_ffi_operation_result(builder_ptr,
Builder._ERROR_MESSAGES[
'builder_error'
].format("Unknown error")
)
except Exception:
if builder_ptr:
ManagedResource._free_native_ptr(builder_ptr)
raise

# Consume-and-return: builder_ptr is consumed,
# new_ptr is the valid pointer going forward
Expand Down
Loading