Fix URL parameter handling for filtering and perPage changes (issue #… #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1208) Fixes issue #1208 where URL refreshing stopped working when using filtering or changing items per page. Only pagination via buttons was working. The problem was that the filterSucceeded() method was adding ALL form filter values to the persistent $filter parameter, including empty ones. This caused URLs to include empty filter parameters like ?grid-filter[name]=, matching the reported regression from version 6.x. Changes: - Only non-empty filter values are now added to the persistent $filter parameter - Empty filter values are explicitly unset from $filter - The $hasNonEmptyFilter flag is now used to determine if filters are active, instead of just checking if values exist - Empty filter values remain stored in session storage for recall, but don't appear in URL parameters This ensures clean URLs and maintains feature parity with version 6.x. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
radimvaculik
force-pushed
the
fix/issue-1208-url-parameter-handling
branch
from
5bc173e to
aefda3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…1208)
Fixes issue #1208 where URL refreshing stopped working when using filtering or changing items per page. Only pagination via buttons was working.
The problem was that the filterSucceeded() method was adding ALL form filter values to the persistent $filter parameter, including empty ones. This caused URLs to include empty filter parameters like ?grid-filter[name]=, matching the reported regression from version 6.x.
Changes:
This ensures clean URLs and maintains feature parity with version 6.x.
🤖 Generated with Claude Code