Skip to content

Conversation

@coord-e
Copy link
Owner

@coord-e coord-e commented Aug 26, 2025

It is also used to construct Assumption; I couldn't come up with a better name.

@coord-e coord-e changed the title Organizing types Introduce PlaceTypeBuilder to simplify PlaceType construction Aug 28, 2025
@coord-e coord-e marked this pull request as ready for review August 28, 2025 12:57
@coord-e coord-e merged commit ac02ab5 into main Aug 30, 2025
3 checks passed
@coord-e coord-e deleted the refactor-types branch August 30, 2025 04:52
@coord-e coord-e requested a review from Copilot August 30, 2025 05:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a PlaceTypeBuilder to streamline the construction of PlaceType and Assumption objects. The builder pattern helps manage existential variable indices properly when combining multiple PlaceTypes and RefinedTypes into a single one.

Key changes:

  • Introduces PlaceTypeBuilder with methods for subsuming types and managing formulas
  • Refactors existing PlaceType methods to use the builder pattern
  • Simplifies code in multiple locations by replacing manual existential variable management

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/refine/env.rs Adds PlaceTypeBuilder struct and refactors PlaceType methods to use it
src/refine.rs Exports the new PlaceTypeBuilder
src/analyze/basic_block.rs Updates code to use PlaceTypeBuilder instead of deprecated PlaceType methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

coeff-aij pushed a commit to coeff-aij/thrust that referenced this pull request Jan 12, 2026
Introduce PlaceTypeBuilder to simplify PlaceType construction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants