Fix a memory leak in set_from()#115
Open
ian-abbott wants to merge 1 commit into
Open
Conversation
Free the allocated 'sender' string when returning NULL on error.
Owner
|
I don't think this is necessary. Failing |
Collaborator
|
IMO changes like this are reasonable even if only to silence potential warnings from static analysis tools. |
Owner
|
fair enough, but all of dma is written with this idiom. It simplifies a lot of code. |
Contributor
|
@corecode : could you please take this change? Something like this would mute complaints from Coverity, cppcheck, etc, even if the program dies shortly after. I realize there are tradeoffs to this, but I would think/hope that the compiler does the right thing by optimizing away the free(3) call, except when -O0 is specified. |
Owner
|
could you attach coverity or cppcheck reports? I'm curious what else is being flagged
…On June 5, 2026 8:21:38 PM CDT, Enji Cooper ***@***.***> wrote:
ngie-eign left a comment (corecode/dma#115)
@corecode : could you please take this change? Something like this would mute complaints from Coverity, cppcheck, etc, even if the program dies shortly after. I realize there are tradeoffs to this, but I would think/hope that the compiler does the right thing by optimizing away the free(3) call, except when -O0 is specified.
Cheers!
--
Reply to this email directly or view it on GitHub:
#115 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free the allocated 'sender' string when returning NULL on error.