Simulate numa nodes #4428
Simulate numa nodes #4428
Conversation
|
Skipping CI for Draft Pull Request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the capability to simulate NUMA nodes in QEMU for external tests. The changes involve adding a NumaNodes option and plumbing it through various layers of the test harness and platform configuration. The core logic for generating QEMU arguments for NUMA is in mantle/platform/qemu.go.
I've identified a couple of issues in the implementation within mantle/platform/qemu.go that could lead to incorrect resource allocation for the simulated NUMA nodes. My review includes suggestions to fix these bugs.
| Timeout time.Duration // the duration for which a test will be allowed to run | ||
| RequiredTag string // if specified, test is filtered by default unless tag is provided -- defaults to none | ||
| Description string // test description | ||
| NumaNodes int // Number of numa nodes to simulate |
There was a problem hiding this comment.
Should we make this an on/off flag where we hardcode 2 NUMA nodes as I don't think we'll test with more than that and maybe that should simplify the code a bit?
There was a problem hiding this comment.
I think this remove the for loop in baseNumaQemuArgs function, but most of the checks would still be quite similar.
Would it be useful to also allow the numaNodes flag with the cosa run command for debugging? If so, allowing an integer may be nice.
If making it a boolean would keep it simpler, and the above is not worth implementing, then I am happy to change it to use a boolean flag.
2 participants
Add an option for external tests to be executed by a machine with multiple numa nodes.