CBL-8161 : Restore the close database timeout waiting for active processes#484
Merged
Conversation
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
Collaborator
Author
|
Fixed a test blocker reported by QE. |
pasin
force-pushed
the
CBL-8161-Restore-Timeout
branch
from
917fecf to
282d14f
Compare
pasin
force-pushed
the
CBL-8161-Restore-Timeout
branch
2 times, most recently
from
4fd2504 to
19b77ce
Compare
…esses * The previous fix reduce the timeout waiting for the active processes to 10 seconds which is too low (e.g. WebSocket close timeout is 9 seconds). Restore the timeout back to 30 seconds. * Restore the previous logic that will try to close the database anyway even though the active processes are not all finished. * Noted that the original code before the fix has a bug that the dabase close only retries once after getting BUSY error but wait for total 30 seconds then timeout after.
pasin
force-pushed
the
CBL-8161-Restore-Timeout
branch
from
19b77ce to
2d4f8f6
Compare
pasin
changed the title
jianminzhao
approved these changes
May 18, 2026
borrrden
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix reduce the timeout waiting for the active processes to 10 seconds which is too low (e.g. WebSocket close timeout is 9 seconds). Restore the timeout back to 30 seconds.
Restore the previous logic that will try to close the database anyway even though the active processes are not all finished.
Noted that the original code before the fix has a bug that the dabase close only retries once after getting BUSY error but wait for total 30 seconds then timeout after.