Explicitly set auto-detect as default for platform#240
Merged
afinetooth merged 1 commit intocoverallsapp:mainfrom Jan 25, 2025
Merged
Explicitly set auto-detect as default for platform#240afinetooth merged 1 commit intocoverallsapp:mainfrom
afinetooth merged 1 commit intocoverallsapp:mainfrom
Conversation
fredden
force-pushed
the
feature/platform-autodetect
branch
from
1027d8c to
438265b
Compare
Contributor
Author
|
@afinetooth as suggested over in PHPCSStandards/PHP_CodeSniffer#791 (comment), I'm happy to adapt this pull request into "remove this parameter" if you would prefer to rely on the auto-detection (ie, |
Member
|
@fredden I like this approach. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #238, where I introduced a feature to automatically detect the platform when none was specified. I failed to notice that there was a default value for the variable of "x86_64" set, which effectively made the code added in #238 useless. In this pull request, I'm setting the default value to
auto-detectso that we can get the correct platform every time.